From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6CAEEC8738 for ; Thu, 7 Sep 2023 16:00:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235876AbjIGQA0 (ORCPT ); Thu, 7 Sep 2023 12:00:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241039AbjIGP7H (ORCPT ); Thu, 7 Sep 2023 11:59:07 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE8E6267DD; Thu, 7 Sep 2023 08:48:05 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 199F3C4E660; Thu, 7 Sep 2023 15:44:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694101467; bh=GexX6pEhOVGWRhrz/ud8wJvXsPGO+Y1DAQecX60cTu0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R36KOoJWRendTTzOmIipDNs/nmQjT2Dy/Tpz/P0Qj+Q6LyvXTjqMpGvVsGJ3P2Nc6 UvcZNIfQPfPzOEHEdanNriYfdKhddL4MtRSEq598cpz+qTD+1VSipd4E/n3aYGMsef mA1eF4R1bM9brVQdYpA2I6psGKDOlNbe5c95yuFCRk9UrjMPOZAY6FEJR1xW8JuCYD 283Snk4r1+Wj5uxXF6K9S1z4vfgnj03fE1gG2L0skbaXy3esPPb2fTE9iryZ/gsit9 Vh0hOUtRAQI5xO5Jdo4GAc+36yISbvz5rGQrXMaW0CLzUrRT9rPNQDE6t32rL5zqWJ a982cLUN+UHOw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Qu Wenruo , David Sterba , Sasha Levin , clm@fb.com, josef@toxicpanda.com, linux-btrfs@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 2/3] btrfs: output extra debug info if we failed to find an inline backref Date: Thu, 7 Sep 2023 11:44:22 -0400 Message-Id: <20230907154423.3422014-2-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230907154423.3422014-1-sashal@kernel.org> References: <20230907154423.3422014-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.256 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Qu Wenruo [ Upstream commit 7f72f50547b7af4ddf985b07fc56600a4deba281 ] [BUG] Syzbot reported several warning triggered inside lookup_inline_extent_backref(). [CAUSE] As usual, the reproducer doesn't reliably trigger locally here, but at least we know the WARN_ON() is triggered when an inline backref can not be found, and it can only be triggered when @insert is true. (I.e. inserting a new inline backref, which means the backref should already exist) [ENHANCEMENT] After the WARN_ON(), dump all the parameters and the extent tree leaf to help debug. Link: https://syzkaller.appspot.com/bug?extid=d6f9ff86c1d804ba2bc6 Signed-off-by: Qu Wenruo Reviewed-by: David Sterba Signed-off-by: David Sterba Signed-off-by: Sasha Levin --- fs/btrfs/extent-tree.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index e47f53e780890..a9191a0d2f4c9 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -895,6 +895,11 @@ int lookup_inline_extent_backref(struct btrfs_trans_handle *trans, err = -ENOENT; goto out; } else if (WARN_ON(ret)) { + btrfs_print_leaf(path->nodes[0]); + btrfs_err(fs_info, +"extent item not found for insert, bytenr %llu num_bytes %llu parent %llu root_objectid %llu owner %llu offset %llu", + bytenr, num_bytes, parent, root_objectid, owner, + offset); err = -EIO; goto out; } -- 2.40.1