From: Alex Williamson <alex.williamson@redhat.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: ankita@nvidia.com, yishaih@nvidia.com,
shameerali.kolothum.thodi@huawei.com, kevin.tian@intel.com,
aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com,
targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com,
apopple@nvidia.com, jhubbard@nvidia.com, danw@nvidia.com,
anuaggarwal@nvidia.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v8 1/1] vfio/nvgpu: Add vfio pci variant module for grace hopper
Date: Thu, 7 Sep 2023 22:04:10 -0600 [thread overview]
Message-ID: <20230907220410.31c6c2ab.alex.williamson@redhat.com> (raw)
In-Reply-To: <ZPpsIU3vAcfFh2e6@nvidia.com>
On Thu, 7 Sep 2023 21:34:41 -0300
Jason Gunthorpe <jgg@nvidia.com> wrote:
> On Thu, Sep 07, 2023 at 01:55:46PM -0600, Alex Williamson wrote:
>
> > There's perhaps an argument whether userspace should compose this
> > device itself, for example finding the firmware attributes in sysfs and
> > directly mmap'ing the coherent memory via /dev/mem to back a virtual
> > BAR or otherwise pass-through this associated region.
>
> I don't think this works, secure boot turns off /dev/mem and other
> things that would let you do this AFAIK.
Yep, it's got issues, just trying to play devil's advocate for a
non-kernel approach.
> > I've previously raised the point whether the coherent region here
> > might be exposed as a device specific region (such as we do for the
> > above IGD regions) rather than a virtual BAR, but the NVIDIA folks feel
> > strongly that the BAR approach is correct.
>
> I think it really depends on what the qemu side wants to do..
Ok, I thought you had been one of the proponents of the fake BAR
approach as more resembling CXL. Do we need to reevaluate that the
tinkering with the VM machine topology and firmware tables would better
align to a device specific region that QEMU inserts into the VM address
space so that bare metal and virtual machine versions of this device
look more similar? Thanks,
Alex
next prev parent reply other threads:[~2023-09-08 4:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 12:41 [PATCH v8 1/1] vfio/nvgpu: Add vfio pci variant module for grace hopper ankita
2023-09-07 19:55 ` Alex Williamson
2023-09-08 0:34 ` Jason Gunthorpe
2023-09-08 4:04 ` Alex Williamson [this message]
2023-09-08 8:50 ` Christoph Hellwig
2023-09-08 12:15 ` Jason Gunthorpe
2023-09-11 7:12 ` Tian, Kevin
2023-09-11 8:17 ` Ankit Agrawal
2023-09-11 8:24 ` Tian, Kevin
2023-09-11 9:19 ` Ankit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230907220410.31c6c2ab.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=acurrid@nvidia.com \
--cc=aniketa@nvidia.com \
--cc=ankita@nvidia.com \
--cc=anuaggarwal@nvidia.com \
--cc=apopple@nvidia.com \
--cc=cjia@nvidia.com \
--cc=danw@nvidia.com \
--cc=hch@infradead.org \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=targupta@nvidia.com \
--cc=vsethi@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox