From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Beau Belgrave <beaub@linux.microsoft.com>,
rostedt@goodmis.org, shuah@kernel.org, mhiramat@kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
naresh.kamboju@linaro.org, anders.roxell@linaro.org,
arnd@arndb.de
Subject: Re: [PATCH v2] selftests/user_events: Fix failures when user_events is not installed
Date: Sat, 9 Sep 2023 10:57:38 +0900 [thread overview]
Message-ID: <20230909105738.edd1c794dc861b60ed010668@kernel.org> (raw)
In-Reply-To: <29fce076-746c-4650-8358-b4e0fa215cf7@sirena.org.uk>
On Sat, 9 Sep 2023 00:33:05 +0100
Mark Brown <broonie@kernel.org> wrote:
> On Fri, Sep 08, 2023 at 08:19:16PM +0000, Beau Belgrave wrote:
>
> > Add common methods to detect if tracefs and user_events is enabled. If
> > either is not enabled skip the test. If tracefs is enabled, but is not
> > mounted, mount tracefs and fail if there were any errors. Fail if not
> > run as root.
>
> This will leave tracefs mounted if it was not already mounted which is a
> change to the system configuration. While that may happen if things go
> wrong during a test we should probably avoid actively doing this and
> either only skip or try to umount at the end of the test if we mounted
> ourselves.
Oh, I didn't know that. I need to update ftracetest to unmount tracefs if
it is not mounted.
Thanks!
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
prev parent reply other threads:[~2023-09-09 1:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 20:19 [PATCH v2] selftests/user_events: Fix failures when user_events is not installed Beau Belgrave
2023-09-08 23:33 ` Mark Brown
2023-09-09 1:27 ` Steven Rostedt
2023-09-12 17:12 ` Beau Belgrave
2023-09-12 17:46 ` Steven Rostedt
2023-09-15 15:54 ` Shuah Khan
2023-09-15 16:02 ` Shuah Khan
2023-09-09 1:57 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230909105738.edd1c794dc861b60ed010668@kernel.org \
--to=mhiramat@kernel.org \
--cc=anders.roxell@linaro.org \
--cc=arnd@arndb.de \
--cc=beaub@linux.microsoft.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox