From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EF3DEEB57C for ; Sat, 9 Sep 2023 09:35:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344491AbjIIJfN (ORCPT ); Sat, 9 Sep 2023 05:35:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343592AbjIIJfL (ORCPT ); Sat, 9 Sep 2023 05:35:11 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 150EF170C for ; Sat, 9 Sep 2023 02:35:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694252107; x=1725788107; h=date:from:to:cc:subject:message-id:mime-version; bh=hy0eqD3QVUOXd4MOm0mTdWs58PSO2AdpkHj5yQBUunA=; b=Z2uU/8Hg45/4gsRB0Y9BmLE+gP6vACg8jLUMtZif8LoiHVik3Mz2YA+g /0LlRXuAJfulxIH2jHIDfqVZH+SkktSDxQJtlRF/Wcxp0GZUUNLw9lBT7 Tqjsqww3scFQZQsAK+m68xjWKEbkq63peRqX7jPVhA46HBiHykDlsBeKU 8TDnA81Kxl04/fFjsY58jEPo4xReWwtZ7cbwVhScG11S6HWdkMWM5rODx 9mzuYN6FbirzT8UCVkMQw39+jy/SZG0N86N/QgehT0NKd3n6PPGjJLetS wsl8r2WFeYEYPJQesFmIK3Mkj5gVEtdB2SSHsd1MlrnYRRYVmWw3ZXhKn g==; X-IronPort-AV: E=McAfee;i="6600,9927,10827"; a="358114016" X-IronPort-AV: E=Sophos;i="6.02,239,1688454000"; d="scan'208";a="358114016" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2023 02:35:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10827"; a="719417146" X-IronPort-AV: E=Sophos;i="6.02,239,1688454000"; d="scan'208";a="719417146" Received: from lkp-server01.sh.intel.com (HELO 59b3c6e06877) ([10.239.97.150]) by orsmga006.jf.intel.com with ESMTP; 09 Sep 2023 02:35:03 -0700 Received: from kbuild by 59b3c6e06877 with local (Exim 4.96) (envelope-from ) id 1qeuMm-0003FY-2S; Sat, 09 Sep 2023 09:35:00 +0000 Date: Sat, 9 Sep 2023 17:34:08 +0800 From: kernel test robot To: Andreas Gruenbacher Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Jens Axboe , Christoph =?iso-8859-1?Q?B=F6hmwalder?= Subject: drivers/block/drbd/drbd_bitmap.c:1222: warning: Function parameter or member 'peer_device' not described in 'drbd_bm_read' Message-ID: <202309091744.vwevUDG1-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andreas, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 6099776f9f268e61fe5ecd721f994a8cfce5306f commit: 8164dd6c8ae158ec0740bf37f0f14645a1fb5355 drbd: Add peer device parameter to whole-bitmap I/O handlers date: 5 months ago config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230909/202309091744.vwevUDG1-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230909/202309091744.vwevUDG1-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202309091744.vwevUDG1-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/block/drbd/drbd_bitmap.c:1222: warning: Function parameter or member 'peer_device' not described in 'drbd_bm_read' >> drivers/block/drbd/drbd_bitmap.c:1234: warning: Function parameter or member 'peer_device' not described in 'drbd_bm_write' >> drivers/block/drbd/drbd_bitmap.c:1246: warning: Function parameter or member 'peer_device' not described in 'drbd_bm_write_all' >> drivers/block/drbd/drbd_bitmap.c:1273: warning: Function parameter or member 'peer_device' not described in 'drbd_bm_write_copy_pages' -- >> drivers/block/drbd/drbd_main.c:3415: warning: Function parameter or member 'peer_device' not described in 'drbd_bmio_set_n_write' >> drivers/block/drbd/drbd_main.c:3441: warning: Function parameter or member 'peer_device' not described in 'drbd_bmio_clear_n_write' >> drivers/block/drbd/drbd_main.c:3502: warning: Function parameter or member 'peer_device' not described in 'drbd_queue_bitmap_io' >> drivers/block/drbd/drbd_main.c:3544: warning: Function parameter or member 'peer_device' not described in 'drbd_bitmap_io' vim +1222 drivers/block/drbd/drbd_bitmap.c b411b3637fa71f Philipp Reisner 2009-09-25 1214 b411b3637fa71f Philipp Reisner 2009-09-25 1215 /** b411b3637fa71f Philipp Reisner 2009-09-25 1216 * drbd_bm_read() - Read the whole bitmap from its on disk location. b30ab7913b0a7b Andreas Gruenbacher 2011-07-03 1217 * @device: DRBD device. b411b3637fa71f Philipp Reisner 2009-09-25 1218 */ 8164dd6c8ae158 Andreas Gruenbacher 2023-03-30 1219 int drbd_bm_read(struct drbd_device *device, 8164dd6c8ae158 Andreas Gruenbacher 2023-03-30 1220 struct drbd_peer_device *peer_device) __must_hold(local) 8164dd6c8ae158 Andreas Gruenbacher 2023-03-30 1221 b411b3637fa71f Philipp Reisner 2009-09-25 @1222 { 4ce4926683b820 Lars Ellenberg 2014-05-06 1223 return bm_rw(device, BM_AIO_READ, 0); b411b3637fa71f Philipp Reisner 2009-09-25 1224 } b411b3637fa71f Philipp Reisner 2009-09-25 1225 b411b3637fa71f Philipp Reisner 2009-09-25 1226 /** b411b3637fa71f Philipp Reisner 2009-09-25 1227 * drbd_bm_write() - Write the whole bitmap to its on disk location. b30ab7913b0a7b Andreas Gruenbacher 2011-07-03 1228 * @device: DRBD device. 19f843aa08e2d8 Lars Ellenberg 2010-12-15 1229 * 19f843aa08e2d8 Lars Ellenberg 2010-12-15 1230 * Will only write pages that have changed since last IO. b411b3637fa71f Philipp Reisner 2009-09-25 1231 */ 8164dd6c8ae158 Andreas Gruenbacher 2023-03-30 1232 int drbd_bm_write(struct drbd_device *device, 8164dd6c8ae158 Andreas Gruenbacher 2023-03-30 1233 struct drbd_peer_device *peer_device) __must_hold(local) b411b3637fa71f Philipp Reisner 2009-09-25 @1234 { 4ce4926683b820 Lars Ellenberg 2014-05-06 1235 return bm_rw(device, 0, 0); b411b3637fa71f Philipp Reisner 2009-09-25 1236 } b411b3637fa71f Philipp Reisner 2009-09-25 1237 d1aa4d04da8de5 Philipp Reisner 2012-08-08 1238 /** d1aa4d04da8de5 Philipp Reisner 2012-08-08 1239 * drbd_bm_write_all() - Write the whole bitmap to its on disk location. b30ab7913b0a7b Andreas Gruenbacher 2011-07-03 1240 * @device: DRBD device. d1aa4d04da8de5 Philipp Reisner 2012-08-08 1241 * d1aa4d04da8de5 Philipp Reisner 2012-08-08 1242 * Will write all pages. d1aa4d04da8de5 Philipp Reisner 2012-08-08 1243 */ 8164dd6c8ae158 Andreas Gruenbacher 2023-03-30 1244 int drbd_bm_write_all(struct drbd_device *device, 8164dd6c8ae158 Andreas Gruenbacher 2023-03-30 1245 struct drbd_peer_device *peer_device) __must_hold(local) d1aa4d04da8de5 Philipp Reisner 2012-08-08 @1246 { 4ce4926683b820 Lars Ellenberg 2014-05-06 1247 return bm_rw(device, BM_AIO_WRITE_ALL_PAGES, 0); d1aa4d04da8de5 Philipp Reisner 2012-08-08 1248 } d1aa4d04da8de5 Philipp Reisner 2012-08-08 1249 c7a58db4e9dc52 Lars Ellenberg 2013-12-20 1250 /** c7a58db4e9dc52 Lars Ellenberg 2013-12-20 1251 * drbd_bm_write_lazy() - Write bitmap pages 0 to @upper_idx-1, if they have changed. c7a58db4e9dc52 Lars Ellenberg 2013-12-20 1252 * @device: DRBD device. c7a58db4e9dc52 Lars Ellenberg 2013-12-20 1253 * @upper_idx: 0: write all changed pages; +ve: page index to stop scanning for changed pages c7a58db4e9dc52 Lars Ellenberg 2013-12-20 1254 */ c7a58db4e9dc52 Lars Ellenberg 2013-12-20 1255 int drbd_bm_write_lazy(struct drbd_device *device, unsigned upper_idx) __must_hold(local) c7a58db4e9dc52 Lars Ellenberg 2013-12-20 1256 { c7a58db4e9dc52 Lars Ellenberg 2013-12-20 1257 return bm_rw(device, BM_AIO_COPY_PAGES, upper_idx); c7a58db4e9dc52 Lars Ellenberg 2013-12-20 1258 } c7a58db4e9dc52 Lars Ellenberg 2013-12-20 1259 0e8488ade26b4b Lars Ellenberg 2012-04-25 1260 /** 0e8488ade26b4b Lars Ellenberg 2012-04-25 1261 * drbd_bm_write_copy_pages() - Write the whole bitmap to its on disk location. b30ab7913b0a7b Andreas Gruenbacher 2011-07-03 1262 * @device: DRBD device. 0e8488ade26b4b Lars Ellenberg 2012-04-25 1263 * 0e8488ade26b4b Lars Ellenberg 2012-04-25 1264 * Will only write pages that have changed since last IO. 0e8488ade26b4b Lars Ellenberg 2012-04-25 1265 * In contrast to drbd_bm_write(), this will copy the bitmap pages 0e8488ade26b4b Lars Ellenberg 2012-04-25 1266 * to temporary writeout pages. It is intended to trigger a full write-out 0e8488ade26b4b Lars Ellenberg 2012-04-25 1267 * while still allowing the bitmap to change, for example if a resync or online 0e8488ade26b4b Lars Ellenberg 2012-04-25 1268 * verify is aborted due to a failed peer disk, while local IO continues, or 0e8488ade26b4b Lars Ellenberg 2012-04-25 1269 * pending resync acks are still being processed. 0e8488ade26b4b Lars Ellenberg 2012-04-25 1270 */ 8164dd6c8ae158 Andreas Gruenbacher 2023-03-30 1271 int drbd_bm_write_copy_pages(struct drbd_device *device, 8164dd6c8ae158 Andreas Gruenbacher 2023-03-30 1272 struct drbd_peer_device *peer_device) __must_hold(local) 0e8488ade26b4b Lars Ellenberg 2012-04-25 @1273 { 4ce4926683b820 Lars Ellenberg 2014-05-06 1274 return bm_rw(device, BM_AIO_COPY_PAGES, 0); 19f843aa08e2d8 Lars Ellenberg 2010-12-15 1275 } 19f843aa08e2d8 Lars Ellenberg 2010-12-15 1276 :::::: The code at line 1222 was first introduced by commit :::::: b411b3637fa71fce9cf2acf0639009500f5892fe The DRBD driver :::::: TO: Philipp Reisner :::::: CC: Jens Axboe -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki