From: Greg KH <gregkh@linuxfoundation.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Saravana Kannan <saravanak@google.com>
Subject: Re: [GIT PULL] Driver symbol lookup fix for 6.6-rc1
Date: Sat, 9 Sep 2023 13:26:00 +0100 [thread overview]
Message-ID: <2023090918-glutton-swampland-db58@gregkh> (raw)
In-Reply-To: <ZPwndquCWHIicVzt@kroah.com>
On Sat, Sep 09, 2023 at 09:06:14AM +0100, Greg KH wrote:
> The following changes since commit a48fa7efaf1161c1c898931fe4c7f0070964233a:
>
> Merge tag 'drm-next-2023-09-08' of git://anongit.freedesktop.org/drm/drm (2023-09-07 19:47:04 -0700)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git tags/driver-core-6.6-rc1-2
>
> for you to fetch changes up to 86495af1171e1feec79faa9b64c05c89f46e41d1:
>
> media: dvb: symbol fixup for dvb_attach() (2023-09-09 08:15:11 +0100)
>
> ----------------------------------------------------------------
> Driver symbol lookup fix for 6.6-rc1
>
> Here is one last fixup for your tree for 6.6-rc1. It resolves a problem
> with the way that symbol_get was changed in the module tree merge in
> your tree to fix up the DVB drivers which rely on this old api to attach
> new devices.
>
> As the changelog comment says:
>
> In commit 9011e49d54dc ("modules: only allow symbol_get of
> EXPORT_SYMBOL_GPL modules") the use of symbol_get is properly restricted
> to GPL-only marked symbols. This interacts oddly with the DVB logic
> which only uses dvb_attach() to load the dvb driver which then uses
> symbol_get().
>
> Fix this up by properly marking all of the dvb_attach attach symbols as
> EXPORT_SYMBOL_GPL().
>
> This has been acked by Hans from the V4L driver side, and from Luis from
> the module side, and Christoph said it was the correct solution, and was
> tested by the original reporter of the issue.
And now Mauro has acked it:
https://lore.kernel.org/r/20230909121941.30a1b1f0@sal.lan
but I don't want to rewrite history to add it to the signed tag.
thanks,
greg k-h
next prev parent reply other threads:[~2023-09-09 12:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-09 8:06 [GIT PULL] Driver symbol lookup fix for 6.6-rc1 Greg KH
2023-09-09 12:26 ` Greg KH [this message]
2023-09-09 18:53 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023090918-glutton-swampland-db58@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saravanak@google.com \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox