From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91FC2EEB57C for ; Sat, 9 Sep 2023 11:01:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344802AbjIILBZ (ORCPT ); Sat, 9 Sep 2023 07:01:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344742AbjIILBX (ORCPT ); Sat, 9 Sep 2023 07:01:23 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A64FE6F for ; Sat, 9 Sep 2023 04:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694257276; x=1725793276; h=date:from:to:cc:subject:message-id:mime-version; bh=xy3SWXT1aEY0HrlDQAb3e72gWVUCFczV6nttQbh0ATw=; b=PejEdtBmNmpHABM3X0g3X/jnWS69CcRlIt0/oFrAq7rNDIjYIfp3Dbk7 L0Xxaqhmj2ufLDjtxiL63PXfxd+avNRN6DxdAYRtd3ALi2sdouPfl6vLy Um9Z84C9PoQuoNc74z07fWRpY3ovCHQFE0RSyy4kbiaG3Nf3xE9ACOZIS Ipe1JrNV68ud7jAeTIrRSQ8tGiUwNI2UMXYhCGY65GrapRrikVrZ5ThDC BHsvp5z8s3dxqHgyHnizLU1Yson10FUZQo9DC0RrfyKBZ2l9kCRXPD/cs LFLqJxd9VDhloyjkdeCYfTmUuniJkQvJjSDkZCCU/LbvLDqnbzsZRZvgf w==; X-IronPort-AV: E=McAfee;i="6600,9927,10827"; a="368073151" X-IronPort-AV: E=Sophos;i="6.02,239,1688454000"; d="scan'208";a="368073151" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2023 04:01:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10827"; a="916464746" X-IronPort-AV: E=Sophos;i="6.02,239,1688454000"; d="scan'208";a="916464746" Received: from lkp-server01.sh.intel.com (HELO 59b3c6e06877) ([10.239.97.150]) by orsmga005.jf.intel.com with ESMTP; 09 Sep 2023 04:01:13 -0700 Received: from kbuild by 59b3c6e06877 with local (Exim 4.96) (envelope-from ) id 1qeviA-0003M0-1u; Sat, 09 Sep 2023 11:01:10 +0000 Date: Sat, 9 Sep 2023 19:01:05 +0800 From: kernel test robot To: Tudor Ambarus Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Vinod Koul Subject: drivers/dma/at_hdmac.c:240: warning: Function parameter or member 'sglen' not described in 'at_desc' Message-ID: <202309091859.gn7xpJhq-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tudor, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 6099776f9f268e61fe5ecd721f994a8cfce5306f commit: ac803b56860f6506c55a3c9330007837e3f4edda dmaengine: at_hdmac: Convert driver to use virt-dma date: 10 months ago config: arm-defconfig (https://download.01.org/0day-ci/archive/20230909/202309091859.gn7xpJhq-lkp@intel.com/config) compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230909/202309091859.gn7xpJhq-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202309091859.gn7xpJhq-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/dma/at_hdmac.c:240: warning: Function parameter or member 'sglen' not described in 'at_desc' drivers/dma/at_hdmac.c:240: warning: Function parameter or member 'boundary' not described in 'at_desc' drivers/dma/at_hdmac.c:240: warning: Function parameter or member 'dst_hole' not described in 'at_desc' drivers/dma/at_hdmac.c:240: warning: Function parameter or member 'src_hole' not described in 'at_desc' drivers/dma/at_hdmac.c:240: warning: Function parameter or member 'memset_buffer' not described in 'at_desc' drivers/dma/at_hdmac.c:240: warning: Function parameter or member 'memset_paddr' not described in 'at_desc' drivers/dma/at_hdmac.c:240: warning: Function parameter or member 'memset_vaddr' not described in 'at_desc' drivers/dma/at_hdmac.c:249: warning: cannot understand function prototype: 'enum atc_status ' >> drivers/dma/at_hdmac.c:284: warning: Function parameter or member 'cyclic' not described in 'at_dma_chan' drivers/dma/at_hdmac.c:348: warning: Function parameter or member 'regs' not described in 'at_dma' drivers/dma/at_hdmac.c:348: warning: Function parameter or member 'memset_pool' not described in 'at_dma' vim +240 drivers/dma/at_hdmac.c ac803b56860f650 Tudor Ambarus 2022-10-25 216 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 217 /** 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 218 * struct at_desc - software descriptor ac803b56860f650 Tudor Ambarus 2022-10-25 219 * @vd: pointer to the virtual dma descriptor. ac803b56860f650 Tudor Ambarus 2022-10-25 220 * @atchan: pointer to the atmel dma channel. 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 221 * @total_len: total transaction byte count ac803b56860f650 Tudor Ambarus 2022-10-25 222 * @sg_len: number of sg entries. ac803b56860f650 Tudor Ambarus 2022-10-25 223 * @sg: array of sgs. 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 224 */ 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 225 struct at_desc { ac803b56860f650 Tudor Ambarus 2022-10-25 226 struct virt_dma_desc vd; ac803b56860f650 Tudor Ambarus 2022-10-25 227 struct at_dma_chan *atchan; 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 228 size_t total_len; ac803b56860f650 Tudor Ambarus 2022-10-25 229 unsigned int sglen; 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 230 /* Interleaved data */ 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 231 size_t boundary; 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 232 size_t dst_hole; 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 233 size_t src_hole; 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 234 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 235 /* Memset temporary buffer */ 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 236 bool memset_buffer; 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 237 dma_addr_t memset_paddr; 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 238 int *memset_vaddr; ac803b56860f650 Tudor Ambarus 2022-10-25 239 struct atdma_sg sg[]; 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 @240 }; 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 241 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 242 /*-- Channels --------------------------------------------------------*/ 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 243 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 244 /** 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 245 * atc_status - information bits stored in channel status flag 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 246 * 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 247 * Manipulated with atomic operations. 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 248 */ 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 249 enum atc_status { 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 250 ATC_IS_PAUSED = 1, 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 251 ATC_IS_CYCLIC = 24, 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 252 }; 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 253 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 254 /** 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 255 * struct at_dma_chan - internal representation of an Atmel HDMAC channel ac803b56860f650 Tudor Ambarus 2022-10-25 256 * @vc: virtual dma channel entry. ac803b56860f650 Tudor Ambarus 2022-10-25 257 * @atdma: pointer to the driver data. 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 258 * @ch_regs: memory mapped register base 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 259 * @mask: channel index in a mask 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 260 * @per_if: peripheral interface 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 261 * @mem_if: memory interface 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 262 * @status: transmit status information from irq/prep* functions 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 263 * to tasklet (use atomic operations) 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 264 * @save_cfg: configuration register that is saved on suspend/resume cycle 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 265 * @save_dscr: for cyclic operations, preserve next descriptor address in 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 266 * the cyclic list on suspend/resume cycle 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 267 * @dma_sconfig: configuration for slave transfers, passed via 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 268 * .device_config ac803b56860f650 Tudor Ambarus 2022-10-25 269 * @desc: pointer to the atmel dma descriptor. 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 270 */ 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 271 struct at_dma_chan { ac803b56860f650 Tudor Ambarus 2022-10-25 272 struct virt_dma_chan vc; ac803b56860f650 Tudor Ambarus 2022-10-25 273 struct at_dma *atdma; 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 274 void __iomem *ch_regs; 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 275 u8 mask; 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 276 u8 per_if; 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 277 u8 mem_if; 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 278 unsigned long status; 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 279 u32 save_cfg; 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 280 u32 save_dscr; 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 281 struct dma_slave_config dma_sconfig; ac803b56860f650 Tudor Ambarus 2022-10-25 282 bool cyclic; ac803b56860f650 Tudor Ambarus 2022-10-25 283 struct at_desc *desc; 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 @284 }; 5cecadc3e2a4fb7 Tudor Ambarus 2022-10-25 285 :::::: The code at line 240 was first introduced by commit :::::: 5cecadc3e2a4fb72ab37d9420df0a9e1179b8a3e dmaengine: at_hdmac: Keep register definitions and structures private to at_hdmac.c :::::: TO: Tudor Ambarus :::::: CC: Vinod Koul -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki