From: Stephen Hemminger <stephen@networkplumber.org>
To: Yajun Deng <yajun.deng@linux.dev>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/core: Export dev_core_stats_rx_dropped_inc sets
Date: Mon, 11 Sep 2023 09:15:13 -0700 [thread overview]
Message-ID: <20230911091513.4f2f2aed@fedora> (raw)
In-Reply-To: <20230911082016.3694700-1-yajun.deng@linux.dev>
On Mon, 11 Sep 2023 16:20:16 +0800
Yajun Deng <yajun.deng@linux.dev> wrote:
> Although there is a kfree_skb_reason() helper function that can be
> used to find the reason for dropped packets, but most callers didn't
> increase one of rx_dropped, tx_dropped, rx_nohandler and
> rx_otherhost_dropped.
>
> For the users, people are more concerned about why the dropped in
> ifconfig is increasing. So we can export
> dev_core_stats_rx_dropped_inc sets, which users would trace them know
> why rx_dropped is increasing.
ifconfig has been frozen for over 10 years, and is deprecated so there
is no point in catering to legacy api's. There are better API's such as
ethtool and netlink that can provide more info.
next prev parent reply other threads:[~2023-09-11 21:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 8:20 [PATCH] net/core: Export dev_core_stats_rx_dropped_inc sets Yajun Deng
2023-09-11 16:15 ` Stephen Hemminger [this message]
2023-09-12 1:42 ` Yajun Deng
2023-09-12 4:23 ` Eric Dumazet
2023-09-12 15:57 ` Alexander Lobakin
2023-09-12 16:04 ` Eric Dumazet
2023-09-12 17:15 ` Alexander Lobakin
2023-09-12 17:28 ` Eric Dumazet
2023-09-12 17:43 ` Alexander Lobakin
2023-09-12 18:03 ` Eric Dumazet
2023-09-12 18:05 ` Eric Dumazet
2023-09-13 2:20 ` Yajun Deng
2023-09-12 16:22 ` Alexander Lobakin
[not found] ` <599cdff8-4865-3ade-0439-36e337891ca0@linux.dev>
2023-09-13 9:58 ` Alexander Lobakin
2023-09-14 2:44 ` Yajun Deng
2023-09-14 14:10 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230911091513.4f2f2aed@fedora \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox