From: Ninad Palsule <ninad@linux.ibm.com>
To: jk@ozlabs.org, joel@jms.id.au, alistair@popple.id.au,
eajames@linux.ibm.com, linux-fsi@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Cc: Ninad Palsule <ninad@linux.ibm.com>
Subject: [PATCH v2 1/2] fsi: sbefifo: Bump up user write cmd length
Date: Mon, 11 Sep 2023 17:38:08 -0500 [thread overview]
Message-ID: <20230911223809.3505431-2-ninad@linux.ibm.com> (raw)
In-Reply-To: <20230911223809.3505431-1-ninad@linux.ibm.com>
This commit increases user write limit for command length from 1MB to
4MB. This is required to support images larger than 1MB.
As per 'commit 15e2a7218c27 ("fsi: sbefifo: Bump max command length")'
the alternate solution is to break image into 1MB pieces by cronous
server that means kernel driver needs to provide way to send end of
message command once all pieces are transferred. This requires
restructuring of both kernel driver and cronus server (application).
Hence this commit chose to bump up cmd length to reduce code impact.
Testing:
Loaded 3 MB image through cronus server.
Signed-off-by: Ninad Palsule <ninad@linux.ibm.com>
---
v2:
- Add the cmd length check back and changed it to 4MB
---
drivers/fsi/fsi-sbefifo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
index 9912b7a6a4b9..a95b32461f8f 100644
--- a/drivers/fsi/fsi-sbefifo.c
+++ b/drivers/fsi/fsi-sbefifo.c
@@ -113,7 +113,7 @@ enum sbe_state
#define SBEFIFO_TIMEOUT_IN_RSP 1000
/* Other constants */
-#define SBEFIFO_MAX_USER_CMD_LEN (0x100000 + PAGE_SIZE)
+#define SBEFIFO_MAX_USER_CMD_LEN (0x400000 + PAGE_SIZE)
#define SBEFIFO_RESET_MAGIC 0x52534554 /* "RSET" */
struct sbefifo {
--
2.39.2
next prev parent reply other threads:[~2023-09-12 1:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 22:38 [PATCH v2 0/2] fsi: sbefifo: fixes Ninad Palsule
2023-09-11 22:38 ` Ninad Palsule [this message]
2023-09-11 22:38 ` [PATCH v2 2/2] fsi: sbefifo: Validate pending user write Ninad Palsule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230911223809.3505431-2-ninad@linux.ibm.com \
--to=ninad@linux.ibm.com \
--cc=alistair@popple.id.au \
--cc=eajames@linux.ibm.com \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox