From: Frederic Weisbecker <frederic@kernel.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Frederic Weisbecker <frederic@kernel.org>,
Joel Fernandes <joel@joelfernandes.org>,
Thomas Gleixner <tglx@linutronix.de>,
vineethrp@gmail.com
Subject: [PATCH 1/5] tick/nohz: Rename the tick handlers to more self-explanatory names
Date: Tue, 12 Sep 2023 12:44:02 +0200 [thread overview]
Message-ID: <20230912104406.312185-2-frederic@kernel.org> (raw)
In-Reply-To: <20230912104406.312185-1-frederic@kernel.org>
The current name of the tick handlers don't tell much about what differ
between them. Use names that better reflect their role and resolution.
Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
---
kernel/time/tick-sched.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 87015e9deacc..b66dd0ff1153 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -1366,7 +1366,7 @@ void tick_nohz_idle_exit(void)
/*
* The nohz low res interrupt handler
*/
-static void tick_nohz_handler(struct clock_event_device *dev)
+static void tick_nohz_lowres_handler(struct clock_event_device *dev)
{
struct tick_sched *ts = this_cpu_ptr(&tick_cpu_sched);
struct pt_regs *regs = get_irq_regs();
@@ -1412,7 +1412,7 @@ static void tick_nohz_switch_to_nohz(void)
if (!tick_nohz_enabled)
return;
- if (tick_switch_to_oneshot(tick_nohz_handler))
+ if (tick_switch_to_oneshot(tick_nohz_lowres_handler))
return;
/*
@@ -1475,7 +1475,7 @@ void tick_irq_enter(void)
* We rearm the timer until we get disabled by the idle code.
* Called with interrupts disabled.
*/
-static enum hrtimer_restart tick_sched_timer(struct hrtimer *timer)
+static enum hrtimer_restart tick_nohz_highres_handler(struct hrtimer *timer)
{
struct tick_sched *ts =
container_of(timer, struct tick_sched, sched_timer);
@@ -1524,7 +1524,7 @@ void tick_setup_sched_timer(void)
* Emulate tick processing via per-CPU hrtimers:
*/
hrtimer_init(&ts->sched_timer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS_HARD);
- ts->sched_timer.function = tick_sched_timer;
+ ts->sched_timer.function = tick_nohz_highres_handler;
/* Get the next period (per-CPU) */
hrtimer_set_expires(&ts->sched_timer, tick_init_jiffy_update());
--
2.34.1
next prev parent reply other threads:[~2023-09-12 10:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 10:44 [PATCH 0/5] tick/nohz: cleanups and fixes v2 Frederic Weisbecker
2023-09-12 10:44 ` Frederic Weisbecker [this message]
2023-09-27 15:01 ` [tip: timers/core] tick/nohz: Rename the tick handlers to more self-explanatory names tip-bot2 for Frederic Weisbecker
2023-09-12 10:44 ` [PATCH 2/5] tick/nohz: Update obsolete comments Frederic Weisbecker
2023-09-27 15:01 ` [tip: timers/core] " tip-bot2 for Frederic Weisbecker
2023-09-28 9:07 ` [PATCH] tick/nohz: Update comments some more Ingo Molnar
2023-09-28 9:11 ` Ingo Molnar
2023-09-29 10:57 ` Frederic Weisbecker
2023-09-29 21:09 ` Ingo Molnar
2023-09-29 22:05 ` Frederic Weisbecker
2023-09-29 21:12 ` [tip: timers/core] " tip-bot2 for Ingo Molnar
2023-09-12 10:44 ` [PATCH 3/5] tick/nohz: Don't shutdown the lowres tick from itself Frederic Weisbecker
2023-09-14 1:17 ` Joel Fernandes
2023-09-14 9:29 ` Frederic Weisbecker
2023-09-14 13:26 ` Joel Fernandes
2023-09-27 15:01 ` [tip: timers/core] " tip-bot2 for Frederic Weisbecker
2023-09-12 10:44 ` [PATCH 4/5] tick/nohz: remove unused tick_nohz_idle_stop_tick_protected() Frederic Weisbecker
2023-09-27 15:01 ` [tip: timers/core] tick/nohz: Remove " tip-bot2 for Xueshi Hu
2023-09-12 10:44 ` [PATCH 5/5] timers: Tag (hr)timer softirq as hotplug safe Frederic Weisbecker
2023-09-16 1:38 ` Joel Fernandes
2023-09-18 17:04 ` Thomas Gleixner
2023-09-27 15:01 ` [tip: timers/core] " tip-bot2 for Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230912104406.312185-2-frederic@kernel.org \
--to=frederic@kernel.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=vineethrp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox