From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DE95CA0ECA for ; Tue, 12 Sep 2023 09:32:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232249AbjILJcT (ORCPT ); Tue, 12 Sep 2023 05:32:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231574AbjILJcS (ORCPT ); Tue, 12 Sep 2023 05:32:18 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B3AFAA; Tue, 12 Sep 2023 02:32:14 -0700 (PDT) Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by madras.collabora.co.uk (Postfix) with ESMTPSA id 9A7DE66072F2; Tue, 12 Sep 2023 10:32:12 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1694511133; bh=eeI0C4r6TV9rH54wW4ZS7WZ8fXen+SsJRbpmKuHbmrQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=F3XA6ZMRhxEcRaaIG78QIW35HZz81I/2rWotiaTcVL5WU/TWALitPEZKC7YJbesGk plFU7O+4PzdXq5QBTfMurrOPmctAlTA5LH+rb5OTsi0Z1deJhaiYZ0DAaEmu1eW62A z9w/P/KGBNcqm5yDBF3tVk1YlwSzsklzR5bqw7gCTF4ApVuZM0nTvuMlmUYXVVKtxI av5ef2inX/fYZrGIRiLI81XBtN7wTd2IJw0macH5QgZ5xyg3VQh6m7ETMkTP611rl8 /8ehZH38kro0WXptil0SQQsDozxYDcoI4/gmS/0BOtxVY5naMBvNMseKVbQt/EQTUH dnVzdy6cU5X5g== Date: Tue, 12 Sep 2023 11:32:10 +0200 From: Boris Brezillon To: =?UTF-8?B?QWRyacOhbg==?= Larumbe Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, robdclark@gmail.com, quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org, sean@poorly.run, marijn.suijten@somainline.org, robh@kernel.org, steven.price@arm.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, healych@amazon.com, kernel@collabora.com, freedreno@lists.freedesktop.org Subject: Re: [PATCH v4 6/6] drm/drm-file: Show finer-grained BO sizes in drm_show_memory_stats Message-ID: <20230912113210.65897aab@collabora.com> In-Reply-To: <20230912084044.955864-7-adrian.larumbe@collabora.com> References: <20230912084044.955864-1-adrian.larumbe@collabora.com> <20230912084044.955864-7-adrian.larumbe@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Sep 2023 09:37:00 +0100 Adri=C3=A1n Larumbe wrote: > The current implementation will try to pick the highest available size > display unit as soon as the BO size exceeds that of the previous > multiplier. That can lead to loss of precision in BO's whose size is > not a multiple of a MiB. >=20 > Fix it by changing the unit selection criteria. >=20 > For much bigger BO's, their size will naturally be aligned on something > bigger than a 4 KiB page, so in practice it is very unlikely their display > unit would default to KiB. Let's wait for Rob's opinion on this. >=20 > Signed-off-by: Adri=C3=A1n Larumbe > --- > drivers/gpu/drm/drm_file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c > index 762965e3d503..bf7d2fe46bfa 100644 > --- a/drivers/gpu/drm/drm_file.c > +++ b/drivers/gpu/drm/drm_file.c > @@ -879,7 +879,7 @@ static void print_size(struct drm_printer *p, const c= har *stat, > unsigned u; > =20 > for (u =3D 0; u < ARRAY_SIZE(units) - 1; u++) { > - if (sz < SZ_1K) > + if (sz & (SZ_1K - 1)) > break; > sz =3D div_u64(sz, SZ_1K); > }