Re: [PATCH 1/4] ASoC: soc-card: Add storage for PCI SSID

Mark Brown
2023-09-13T12:58:36Z

[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]

On Wed, Sep 13, 2023 at 12:56:03PM +0200, Amadeusz Sławiński wrote:
> On 9/12/2023 6:32 PM, Richard Fitzgerald wrote:

> > +#ifdef CONFIG_PCI
> > + /*
> > + * PCI does not define 0 as invalid, so pci_subsystem_set indicates
> > + * whether a value has been written to these fields.
> > + */
> > + unsigned short pci_subsystem_vendor;
> > + unsigned short pci_subsystem_device;
> > + bool pci_subsystem_set;
> > +#endif /* CONFIG_PCI */
> > +
> > char topology_shortname[32];
> > struct device *dev;

> This looks bit weird to me, snd_soc_card is _generic_ struct which is not
> device specific in any way, and now you add fields for PCI, can't this
> somehow be done using drvdata or something?

You're right that it's a bit messy but if we use driver data then it
becomes specific to a particular driver and there's a goal here to share
with subfunction drivers. I was thinking we could refactor to a union
or otherwise extend if we find other users with a similar need.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]