From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [for-linus][PATCH 0/3] tracing: Some more fixes before pushing to 6.6
Date: Tue, 12 Sep 2023 14:22:13 -0400 [thread overview]
Message-ID: <20230912182213.795801173@goodmis.org> (raw)
Tracing updates for 6.6:
- Fix NULL pointer dereference with eventfs_remove_rec()
If an allocation fails in one of the eventfs_add_*() functions,
the caller of it in event_subsystem_dir() or event_create_dir()
assigns the result to the structure. But it's assigning the ERR_PTR
and not NULL. This was passed to eventfs_remove_rec() which expects
either a good pointer or a NULL, not ERR_PTR. The fix is to not
assign the ERR_PTR to the structure, but to keep it NULL on error.
- Fix list_for_each_rcu() to use list_for_each_srcu() in
dcache_dir_open_wrapper(). One iteration of the code used RCU
but because it had to call sleepable code, it had to be changed
to use SRCU, but one of the iterations was missed.
- Fix synthetic event print function to use "as_u64" instead of
passing in a pointer to the union. To fix big/little endian issues,
the u64 that represented several types was turned into a union to
define the types properly.
git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git
trace/urgent
Head SHA1: c8414dab164a74bd3bb859a2d836cb537d6b9298
Jinjie Ruan (1):
eventfs: Fix the NULL pointer dereference bug in eventfs_remove_rec()
Steven Rostedt (Google) (1):
tracefs/eventfs: Use list_for_each_srcu() in dcache_dir_open_wrapper()
Tero Kristo (1):
tracing/synthetic: Print out u64 values properly
----
fs/tracefs/event_inode.c | 3 ++-
kernel/trace/trace_events.c | 13 +++++++++----
kernel/trace/trace_events_synth.c | 2 +-
3 files changed, 12 insertions(+), 6 deletions(-)
next reply other threads:[~2023-09-12 18:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 18:22 Steven Rostedt [this message]
2023-09-12 18:22 ` [for-linus][PATCH 1/3] tracing/synthetic: Print out u64 values properly Steven Rostedt
2023-09-12 18:22 ` [for-linus][PATCH 2/3] tracefs/eventfs: Use list_for_each_srcu() in dcache_dir_open_wrapper() Steven Rostedt
2023-09-12 18:22 ` [for-linus][PATCH 3/3] eventfs: Fix the NULL pointer dereference bug in eventfs_remove_rec() Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230912182213.795801173@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox