public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Andreas Kemnade <andreas@kemnade.info>,
	Sebastian Reichel <sre@kernel.org>
Cc: tomi.valkeinen@ideasonboard.com, airlied@gmail.com,
	daniel@ffwll.ch, u.kleine-koenig@pengutronix.de, arnd@arndb.de,
	laurent.pinchart@ideasonboard.com,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	linux-omap@vger.kernel.org
Subject: Re: [RFC PATCH] drm: omapdrm: dsi: add refsel also for omap4
Date: Wed, 13 Sep 2023 10:15:39 +0300	[thread overview]
Message-ID: <20230913071539.GD5285@atomide.com> (raw)
In-Reply-To: <20230913065911.1551166-1-andreas@kemnade.info>

* Andreas Kemnade <andreas@kemnade.info> [230913 06:59]:
> Some 3.0 source has it set behind a if (omap4).
> Maybe it is helpful maybe not, at least in the omap4460
> trm these bits are marked as reserved.
> But maybe some dsi video mode panel starts magically working.

Interesting. So Andreas mentioned that dsi video mode works on omap5
but not on omap4. Adding Sebastian to the list too.

Regards,

Tony

> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  drivers/gpu/drm/omapdrm/dss/dsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
> index 60189a23506a1..e2f576cd9f63c 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dsi.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
> @@ -4505,7 +4505,7 @@ static const struct dss_pll_hw dss_omap4_dsi_pll_hw = {
>  	.has_stopmode = true,
>  	.has_freqsel = false,
>  	.has_selfreqdco = false,
> -	.has_refsel = false,
> +	.has_refsel = true,
>  };
>  
>  static const struct dss_pll_hw dss_omap5_dsi_pll_hw = {
> -- 
> 2.39.2
> 

  reply	other threads:[~2023-09-13  7:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-13  6:59 [RFC PATCH] drm: omapdrm: dsi: add refsel also for omap4 Andreas Kemnade
2023-09-13  7:15 ` Tony Lindgren [this message]
2023-09-13 12:11 ` Tomi Valkeinen
2023-09-13 12:48   ` Tony Lindgren
2023-09-13 12:58     ` Tomi Valkeinen
2023-09-17 14:34       ` Andreas Kemnade
2023-09-13 16:52   ` Andreas Kemnade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230913071539.GD5285@atomide.com \
    --to=tony@atomide.com \
    --cc=airlied@gmail.com \
    --cc=andreas@kemnade.info \
    --cc=arnd@arndb.de \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=sre@kernel.org \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox