Re: [PATCH 2/5] mtd: rawnand: ingenic: use gpiod_set_active_high()

Linus Walleij
2023-09-13T20:12:56Z

On Wed, Sep 13, 2023 at 10:05 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Wed, Sep 13, 2023 at 2:50 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > Use the new, less cumbersome interface for setting the GPIO as
> > active-high that doesn't require first checking the current state.
>
> ...
>
> > * here for older DTs so we can re-use the generic nand_gpio_waitrdy()
> > * helper, and be consistent with what other drivers do.
> > */
> > - if (of_machine_is_compatible("qi,lb60") &&
> > - gpiod_is_active_low(nand->busy_gpio))
> > - gpiod_toggle_active_low(nand->busy_gpio);
> > + if (of_machine_is_compatible("qi,lb60"))
> > + gpiod_set_active_high(nand->busy_gpio);
>
> Why not moving this quirk to gpiolib-of.c?

That's a better idea here I think, it's clearly a quirk for a
buggy device tree.

Yours,
Linus Walleij