Re: [PATCH 4/5] platform/x86: int3472/discrete: use gpiod_set_active_low()

Hans de Goede
2023-09-13T14:51:43Z

Hi,

On 9/13/23 13:50, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Use the new polarity setter instead of the more cumbersome toggle
> function.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> drivers/platform/x86/intel/int3472/clk_and_regulator.c | 2 +-
> drivers/platform/x86/intel/int3472/led.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/intel/int3472/clk_and_regulator.c b/drivers/platform/x86/intel/int3472/clk_and_regulator.c
> index ef4b3141efcd..31e520838b95 100644
> --- a/drivers/platform/x86/intel/int3472/clk_and_regulator.c
> +++ b/drivers/platform/x86/intel/int3472/clk_and_regulator.c
> @@ -183,7 +183,7 @@ int skl_int3472_register_gpio_clock(struct int3472_discrete_device *int3472,
> }
>
> if (polarity == GPIO_ACTIVE_LOW)
> - gpiod_toggle_active_low(int3472->clock.ena_gpio);
> + gpiod_set_active_low(int3472->clock.ena_gpio);
>
> /* Ensure the pin is in output mode and non-active state */
> gpiod_direction_output(int3472->clock.ena_gpio, 0);
> diff --git a/drivers/platform/x86/intel/int3472/led.c b/drivers/platform/x86/intel/int3472/led.c
> index bca1ce7d0d0c..46c9c569df5e 100644
> --- a/drivers/platform/x86/intel/int3472/led.c
> +++ b/drivers/platform/x86/intel/int3472/led.c
> @@ -32,7 +32,7 @@ int skl_int3472_register_pled(struct int3472_discrete_device *int3472,
> "getting privacy LED GPIO\n");
>
> if (polarity == GPIO_ACTIVE_LOW)
> - gpiod_toggle_active_low(int3472->pled.gpio);
> + gpiod_set_active_low(int3472->pled.gpio);
>
> /* Ensure the pin is in output mode and non-active state */
> gpiod_direction_output(int3472->pled.gpio, 0);

Thanks. I agree that the new API is much better:

Acked-by: Hans de Goede <hdegoede@redhat.com>

Feel free to merge this through the GPIO tree.

Regards,

Hans