public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: chengming.zhou@linux.dev
To: mingo@redhat.com, peterz@infradead.org
Cc: linux-kernel@vger.kernel.org, chengming.zhou@linux.dev,
	Chengming Zhou <zhouchengming@bytedance.com>,
	Leo Yu-Chi Liang <ycliang@andestech.com>,
	Vincent Guittot <vincent.guittot@linaro.org>
Subject: [PATCH v2] sched/fair: Fix cfs_rq_is_decayed() on !SMP
Date: Wed, 13 Sep 2023 13:20:31 +0000	[thread overview]
Message-ID: <20230913132031.2242151-1-chengming.zhou@linux.dev> (raw)

From: Chengming Zhou <zhouchengming@bytedance.com>

We don't need to maintain per-queue leaf_cfs_rq_list on !SMP, since
it's used for cfs_rq load tracking & balance on SMP.

But sched debug interface use it to print per-cfs_rq stats, which
maybe better to change to use walk_tg_tree_from() instead.

This patch just fix the !SMP version cfs_rq_is_decayed(), so the
per-queue leaf_cfs_rq_list is also maintained correctly on !SMP,
to fix the warning in assert_list_leaf_cfs_rq().

Fixes: 0a00a354644e ("sched/fair: Delete useless condition in tg_unthrottle_up()")
Reported-by: Leo Yu-Chi Liang <ycliang@andestech.com>
Closes: https://lore.kernel.org/all/ZN87UsqkWcFLDxea@swlinux02/
Tested-by: Leo Yu-Chi Liang <ycliang@andestech.com>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
---
 kernel/sched/fair.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 8dbff6e7ad4f..845d7729320e 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -4878,7 +4878,7 @@ static inline void update_misfit_status(struct task_struct *p, struct rq *rq)
 
 static inline bool cfs_rq_is_decayed(struct cfs_rq *cfs_rq)
 {
-	return true;
+	return !(cfs_rq->nr_running);
 }
 
 #define UPDATE_TG	0x0
-- 
2.40.1


             reply	other threads:[~2023-09-13 13:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-13 13:20 chengming.zhou [this message]
2023-09-15 12:26 ` [tip: sched/core] sched/fair: Fix cfs_rq_is_decayed() on !SMP tip-bot2 for Chengming Zhou
  -- strict thread matches above, loose matches on Subject: below --
2023-08-18  9:35 PROBLEM: LTP cfs_bandwidth01 test bumped into SCHED_WARN_ON after de-selecting CONFIG_SMP Leo Liang
2023-08-18 13:21 ` [PATCH v2] sched/fair: Fix cfs_rq_is_decayed() on !SMP chengming.zhou
2023-08-21  1:29   ` Leo Liang
2023-08-21 11:59   ` Vincent Guittot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230913132031.2242151-1-chengming.zhou@linux.dev \
    --to=chengming.zhou@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=vincent.guittot@linaro.org \
    --cc=ycliang@andestech.com \
    --cc=zhouchengming@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox