From: <cheng.lin130@zte.com.cn>
To: <david@fromorbit.com>, <djwong@kernel.org>
Cc: <linux-xfs@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<jiang.yong5@zte.com.cn>, <wang.liang82@zte.com.cn>,
<liu.dong3@zte.com.cn>
Subject: [PATCH v3] xfs: introduce protection for drop nlink
Date: Wed, 13 Sep 2023 17:44:45 +0800 (CST) [thread overview]
Message-ID: <202309131744458239465@zte.com.cn> (raw)
From: Cheng Lin <cheng.lin130@zte.com.cn>
When abnormal drop_nlink are detected on the inode,
shutdown filesystem, to avoid corruption propagation.
Signed-off-by: Cheng Lin <cheng.lin130@zte.com.cn>
---
fs/xfs/xfs_inode.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
index 9e62cc500..40cc106ae 100644
--- a/fs/xfs/xfs_inode.c
+++ b/fs/xfs/xfs_inode.c
@@ -919,6 +919,15 @@ xfs_droplink(
xfs_trans_t *tp,
xfs_inode_t *ip)
{
+
+ if (VFS_I(ip)->i_nlink == 0) {
+ xfs_alert(ip->i_mount,
+ "%s: Deleting inode %llu with no links.",
+ __func__, ip->i_ino);
+ tp->t_flags |= XFS_TRANS_DIRTY;
+ return -EFSCORRUPTED;
+ }
+
xfs_trans_ichgtime(tp, ip, XFS_ICHGTIME_CHG);
drop_nlink(VFS_I(ip));
--
2.18.1
next reply other threads:[~2023-09-13 9:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 9:44 cheng.lin130 [this message]
2023-09-13 23:42 ` [PATCH v3] xfs: introduce protection for drop nlink Dave Chinner
2023-09-15 8:20 ` cheng.lin130
2023-09-15 9:50 ` cheng.lin130
2023-09-17 22:44 ` Dave Chinner
2023-09-18 3:44 ` cheng.lin130
2023-09-18 5:48 ` Dave Chinner
2023-09-18 6:34 ` cheng.lin130
2023-09-19 3:33 ` Darrick J. Wong
2023-09-20 5:53 ` Dave Chinner
2023-10-03 17:33 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202309131744458239465@zte.com.cn \
--to=cheng.lin130@zte.com.cn \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=jiang.yong5@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=liu.dong3@zte.com.cn \
--cc=wang.liang82@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox