Re: [PATCH v4 07/12] x86/tdx: Make TDX_HYPERCALL asm similar to TDX_MODULE_CALL

kirill.shutemov
2023-08-25T23:38:20Z

On Tue, Aug 15, 2023 at 11:02:01PM +1200, Kai Huang wrote:
> + /*
> + * Failure of __tdcall_hypercall() indicates a failure of the TDVMCALL
> + * mechanism itself and that something has gone horribly wrong with
> + * the TDX module. __tdx_hypercall_failed() never returns.
> + */
> + if (__tdcall_hypercall(TDG_VP_VMCALL, &margs))
> + __tdx_hypercall_failed();

Do we even need __tdx_hypercall_failed() anymore? Just call panic()
directly, no?

--
Kiryl Shutsemau / Kirill A. Shutemov