Re: [PATCH v4 00/12] Unify TDCALL/SEAMCALL and TDVMCALL assembly

Huang, Kai
2023-09-12T02:14:28Z

On Mon, 2023-09-11 at 19:08 +0200, Paolo Bonzini wrote:
> On 8/15/23 13:01, Kai Huang wrote:
> > Hi Peter, Kirill,
> >
> > This series unifies the assembly code for TDCALL/SEAMCALL and TDVMCALL.
> > Now all of them use one singe TDX_MODULE_CALL asm macro. More
> > information please see cover letter of v2 (see link below).
> >
> > Tested by booting TDX guest, initializing TDX module, and running TDX
> > guest successfully, all with this series applied.
>
> Not sure it if's new in this version but I'm seeing
>
> WARNING: modpost: EXPORT symbol "__seamcall_ret" [vmlinux] version ...
> Is "__seamcall_ret" prototyped in <asm/asm-prototypes.h>?
> WARNING: modpost: EXPORT symbol "__seamcall" [vmlinux] version ...
> Is "__seamcall" prototyped in <asm/asm-prototypes.h>?
> WARNING: modpost: EXPORT symbol "__seamcall_saved_ret" [vmlinux] version ...
> Is "__seamcall_saved_ret" prototyped in <asm/asm-prototypes.h>?
>
> which is fixed by
>
> diff --git a/arch/x86/include/asm/asm-prototypes.h b/arch/x86/include/asm/asm-prototypes.h
> index 8f80de627c60..eff5252e9c86 100644
> --- a/arch/x86/include/asm/asm-prototypes.h
> +++ b/arch/x86/include/asm/asm-prototypes.h
> @@ -6,6 +6,7 @@
> #include <asm/page.h>
> #include <asm/checksum.h>
> #include <asm/mce.h>
> +#include <asm/tdx.h>
>
> #include <asm-generic/asm-prototypes.h>
>

Thanks Paolo!

I never met this issue, not even from LKP. Do you happen to know which Kconfig
option can trigger this? Or would you mind sharing your .config?