Re: [PATCH v4 00/12] Unify TDCALL/SEAMCALL and TDVMCALL assembly

Peter Zijlstra
2023-09-06T11:57:53Z

On Tue, Sep 05, 2023 at 11:01:28PM +0000, Huang, Kai wrote:
> On Tue, 2023-08-15 at 23:01 +1200, Kai Huang wrote:
> > Hi Peter, Kirill,
> >
> > This series unifies the assembly code for TDCALL/SEAMCALL and TDVMCALL.
> > Now all of them use one singe TDX_MODULE_CALL asm macro. More
> > information please see cover letter of v2 (see link below).
> >
> > Tested by booting TDX guest, initializing TDX module, and running TDX
> > guest successfully, all with this series applied.
> >
> >
>
> Hi Peter,
>
> Sorry to ping, but could you take a look whether you are OK with this series?
>
> Basically Kirill has provided his Reviewed-by for all the patches except the
> last one (Add unused registers to 'struct tdx_module_args' to optimize VP.ENTER
> for KVM), which he didn't like. But it is pretty much a standalone optimization
> patch we either can have or drop when applying, so I'll leave to you.
>
> Also feel free to let me know if I can help you on anything to offload part of
> your load? :-)

This looks good, thanks!

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>