From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2928DEE0213 for ; Thu, 14 Sep 2023 00:24:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232897AbjINAXw (ORCPT ); Wed, 13 Sep 2023 20:23:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229485AbjINAXu (ORCPT ); Wed, 13 Sep 2023 20:23:50 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AF25E4B for ; Wed, 13 Sep 2023 17:23:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694651026; x=1726187026; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ibRPzuTs9RlH2bygxH3UxKliLnlVLu0fWmJh4zT8MoQ=; b=Qoe/gzvIEHOKGH9akbYmZV5gG/pnRsUgqNgHpL9gqjl6TapB8Htz8iZV 5I5tR+MyK8+8qSekafX4knq6gxMdkMuRitFA7pPQB4Bp7Ob3xfUo72xjs Ob9JX7cHxbTLy37zBnHcpG+BHqlYH8bAIQlq7zgzfhN9XfQhY0Ueqx7aH xm6wDqXMbPggZCFdCZaLnFQ6hVFSsDI0X1WoPiXtQKlXzhjz8eYe35G18 IZoUDq3v/yZ81hYZcXtEHSGbDW80L7N1KegWL20oFZ5ct2oeM4BLgShdg vGkNx2MmfkYPbzSgPuRNC9GAS2CbD1rkPfthYktkYrGD857ai8fAAUIcP A==; X-IronPort-AV: E=McAfee;i="6600,9927,10832"; a="377726434" X-IronPort-AV: E=Sophos;i="6.02,144,1688454000"; d="scan'208";a="377726434" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2023 17:23:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10832"; a="747522457" X-IronPort-AV: E=Sophos;i="6.02,144,1688454000"; d="scan'208";a="747522457" Received: from ls.sc.intel.com (HELO localhost) ([172.25.112.31]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2023 17:23:26 -0700 Date: Wed, 13 Sep 2023 17:23:25 -0700 From: Isaku Yamahata To: Paolo Bonzini Cc: "Huang, Kai" , "kirill.shutemov@linux.intel.com" , "peterz@infradead.org" , "linux-kernel@vger.kernel.org" , "Hansen, Dave" , "Christopherson,, Sean" , "bp@alien8.de" , "x86@kernel.org" , "hpa@zytor.com" , "mingo@redhat.com" , "tglx@linutronix.de" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Yamahata, Isaku" , "n.borisov.lkml@gmail.com" , isaku.yamahata@linux.intel.com Subject: Re: [PATCH v4 00/12] Unify TDCALL/SEAMCALL and TDVMCALL assembly Message-ID: <20230914002325.GD3638268@ls.amr.corp.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 12, 2023 at 03:37:49PM +0200, Paolo Bonzini wrote: > On 9/12/23 02:57, Huang, Kai wrote: > > > > +#include > > > > > > > > #include > > > > > > > Thanks Paolo! > > > > > > I never met this issue, not even from LKP. Do you happen to know > > > which Kconfig option can trigger this? Or would you mind sharing > > > your .config? > > (replying via outlook due to some networking issue of my home > > network) > > > > After digging, this is due to exporting __seamcall*() assembly > > functions while MODVERSIONS is enabled. > > > > This series itself doesn't cause this warning. > > > > I didn't export them in this series because I would like to leave to > > KVM patches when we are sure we need to export them. > > > > E.g., I have seamcall*() wrappers to retry running out of entropy, > > and we may have concern exporting __seamcall*() low level functions > > directly and may wish to export higher level wrappers. > > > > So I think the fix should be with the patch that truly exports those > > __seamcall*(). I'll talk to Isaku on this to get his idea. > > Ah indeed it's not caused by your patches, but rather by the Isaku's KVM TDX > support ("KVM: TDX: Add C wrapper functions for SEAMCALLs to the TDX > module"). The fix is just to squash the #include into his patch. Yes, I'll squash the fix into the patch. -- Isaku Yamahata