From: Lee Jones <lee@kernel.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Charles Keepax <ckeepax@opensource.cirrus.com>,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
geert@linux-m68k.org
Subject: Re: [PATCH] mfd: cs42l43: Use correct macro for new-style PM runtime ops
Date: Thu, 14 Sep 2023 11:19:47 +0100 [thread overview]
Message-ID: <20230914101947.GM13143@google.com> (raw)
In-Reply-To: <87zg20cfkm.fsf@mail.lhotse>
On Wed, 06 Sep 2023, Michael Ellerman wrote:
> Lee Jones <lee@kernel.org> writes:
> > On Tue, 22 Aug 2023, Charles Keepax wrote:
> >
> >> The code was accidentally mixing new and old style macros, update the
> >> macros used to remove an unused function warning whilst building with
> >> no PM enabled in the config.
> >>
> >> Fixes: ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
> >> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> >> ---
> >> drivers/mfd/cs42l43.c | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/mfd/cs42l43.c b/drivers/mfd/cs42l43.c
> >> index 37b23e9bae823..7b6d07cbe6fc6 100644
> >> --- a/drivers/mfd/cs42l43.c
> >> +++ b/drivers/mfd/cs42l43.c
> >> @@ -1178,8 +1178,8 @@ static int cs42l43_runtime_resume(struct device *dev)
> >> }
> >>
> >> EXPORT_NS_GPL_DEV_PM_OPS(cs42l43_pm_ops, MFD_CS42L43) = {
> >> - SET_SYSTEM_SLEEP_PM_OPS(cs42l43_suspend, cs42l43_resume)
> >> - SET_RUNTIME_PM_OPS(cs42l43_runtime_suspend, cs42l43_runtime_resume, NULL)
> >> + SYSTEM_SLEEP_PM_OPS(cs42l43_suspend, cs42l43_resume)
> >> + RUNTIME_PM_OPS(cs42l43_runtime_suspend, cs42l43_runtime_resume, NULL)
> >> };
> >>
> >> MODULE_DESCRIPTION("CS42L43 Core Driver");
> >
> > Acked-by: Lee Jones <lee@kernel.org>
> >
> > If anyone wants to submit this directly to Linus before -rc1, please, be
> > my guest.
>
> But you're the MFD maintainer, aren't you? So I think everyone is
> expecting you to send it to Linus.
And I will. The offer was in case anyone (with more spare time than I)
wanted to send it before I had a chance.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-09-14 10:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 11:49 [PATCH] mfd: cs42l43: Use correct macro for new-style PM runtime ops Charles Keepax
2023-08-30 11:08 ` Geert Uytterhoeven
2023-08-30 15:45 ` Nathan Chancellor
2023-09-04 14:40 ` Lee Jones
2023-09-06 0:26 ` Michael Ellerman
2023-09-06 10:37 ` Geert Uytterhoeven
2023-09-14 10:19 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230914101947.GM13143@google.com \
--to=lee@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox