From: Sean Christopherson <seanjc@google.com>
To: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Pattara Teerapong <pteerapong@google.com>,
David Stevens <stevensd@google.com>,
Yiwei Zhang <zzyiwei@google.com>, Paul Hsia <paulhsia@google.com>
Subject: [PATCH 0/3] KVM: x86/mmu: Drop async zapping of TDP MMU roots
Date: Fri, 15 Sep 2023 17:39:13 -0700 [thread overview]
Message-ID: <20230916003916.2545000-1-seanjc@google.com> (raw)
Yank out the asynchronous zapping of TDP MMU roots. In some setups, using
unbounded workqueues can consumes all CPUs for extended durations, and
create significant jitter in the system.
Specifically, the behavior causes audio glitches in ChromeOS VMs with
virtio-gpu when running games in the guest. Gory details in patch 3.
I tagged all of this for stable so that this gets back to v6.1 (I already
did the backport to verify it's not awful). This bug is bad enough that
the workaround for the ChromeOS usecase is to simply disable the TDP MMU,
which I really do not want to do for the v6.1 kernel (or the v6.6. kernel).
Sean Christopherson (3):
KVM: x86/mmu: Open code walking TDP MMU roots for mmu_notifier's zap
SPTEs
KVM: x86/mmu: Take "shared" instead of "as_id" TDP MMU's yield-safe
iterator
KVM: x86/mmu: Stop zapping invalidated TDP MMU roots asynchronously
arch/x86/include/asm/kvm_host.h | 3 +-
arch/x86/kvm/mmu/mmu.c | 21 ++---
arch/x86/kvm/mmu/mmu_internal.h | 13 ++-
arch/x86/kvm/mmu/tdp_mmu.c | 147 ++++++++++++++------------------
arch/x86/kvm/mmu/tdp_mmu.h | 5 +-
arch/x86/kvm/x86.c | 5 +-
6 files changed, 80 insertions(+), 114 deletions(-)
base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d
--
2.42.0.459.ge4e396fd5e-goog
next reply other threads:[~2023-09-16 0:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-16 0:39 Sean Christopherson [this message]
2023-09-16 0:39 ` [PATCH 1/3] KVM: x86/mmu: Open code walking TDP MMU roots for mmu_notifier's zap SPTEs Sean Christopherson
2023-09-21 10:05 ` Paolo Bonzini
2023-09-16 0:39 ` [PATCH 2/3] KVM: x86/mmu: Take "shared" instead of "as_id" TDP MMU's yield-safe iterator Sean Christopherson
2023-09-21 10:52 ` Paolo Bonzini
2023-09-21 14:32 ` Sean Christopherson
2023-09-16 0:39 ` [PATCH 3/3] KVM: x86/mmu: Stop zapping invalidated TDP MMU roots asynchronously Sean Christopherson
2023-09-21 10:02 ` Paolo Bonzini
2023-09-22 20:40 ` [PATCH 0/3] KVM: x86/mmu: Drop async zapping of TDP MMU roots Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230916003916.2545000-1-seanjc@google.com \
--to=seanjc@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulhsia@google.com \
--cc=pbonzini@redhat.com \
--cc=pteerapong@google.com \
--cc=stevensd@google.com \
--cc=zzyiwei@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox