public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [RFC v1] arm64: dts: mediatek: add dtbs with applied overlays for bpi-r3
@ 2023-09-16  8:32 Frank Wunderlich
  2023-09-30 12:57 ` Aw: " Frank Wunderlich
  0 siblings, 1 reply; 7+ messages in thread
From: Frank Wunderlich @ 2023-09-16  8:32 UTC (permalink / raw)
  To: linux-mediatek
  Cc: Frank Wunderlich, Matthias Brugger, AngeloGioacchino Del Regno,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-kernel,
	linux-arm-kernel

From: Frank Wunderlich <frank-w@public-files.de>

Build devicetree binaries for testing overlays and providing users
full dtb without using overlays.

Suggested-by: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
based on discussion here:
https://lore.kernel.org/all/CAL_JsqK_3xxD0DFwipXO85P=q=EYjUdjE1_8g1MKtvw3vVzx5A@mail.gmail.com/
https://lore.kernel.org/all/CAL_JsqJSi=kJSix=f3787ULZnaCy_Y26Phdhy5y9fat_vkDuUw@mail.gmail.com/
---
 arch/arm64/boot/dts/mediatek/Makefile | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
index c99c3372a4b5..18be027bf6b4 100644
--- a/arch/arm64/boot/dts/mediatek/Makefile
+++ b/arch/arm64/boot/dts/mediatek/Makefile
@@ -13,6 +13,14 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtbo
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd.dtbo
+mt7986a-bananapi-bpi-r3-emmc-nand-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-emmc.dtbo mt7986a-bananapi-bpi-r3-nand.dtbo
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nand.dtb
+mt7986a-bananapi-bpi-r3-emmc-nor-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-emmc.dtbo mt7986a-bananapi-bpi-r3-nor.dtbo
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nor.dtb
+mt7986a-bananapi-bpi-r3-sd-nand-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-sd.dtbo mt7986a-bananapi-bpi-r3-nand.dtbo
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nand.dtb
+mt7986a-bananapi-bpi-r3-sd-nor-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-sd.dtbo mt7986a-bananapi-bpi-r3-nor.dtbo
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nor.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-rfb.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986b-rfb.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt8167-pumpkin.dtb
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Aw: [RFC v1] arm64: dts: mediatek: add dtbs with applied overlays for bpi-r3
  2023-09-16  8:32 [RFC v1] arm64: dts: mediatek: add dtbs with applied overlays for bpi-r3 Frank Wunderlich
@ 2023-09-30 12:57 ` Frank Wunderlich
  2023-10-23 11:59   ` Frank Wunderlich
  2023-10-25 13:10   ` Frank Wunderlich
  0 siblings, 2 replies; 7+ messages in thread
From: Frank Wunderlich @ 2023-09-30 12:57 UTC (permalink / raw)
  To: Rob Herring
  Cc: linux-mediatek, Matthias Brugger, AngeloGioacchino Del Regno,
	Krzysztof Kozlowski, Conor Dooley, linux-kernel, linux-arm-kernel,
	Frank Wunderlich

Hi,

just a friendly reminder...is this the right way to go?

regards Frank


> Gesendet: Samstag, 16. September 2023 um 10:32 Uhr
> Von: "Frank Wunderlich" <linux@fw-web.de>
> An: linux-mediatek@lists.infradead.org
> Cc: "Frank Wunderlich" <frank-w@public-files.de>, "Matthias Brugger" <matthias.bgg@gmail.com>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Conor Dooley" <conor+dt@kernel.org>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
> Betreff: [RFC v1] arm64: dts: mediatek: add dtbs with applied overlays for bpi-r3
>
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Build devicetree binaries for testing overlays and providing users
> full dtb without using overlays.
>
> Suggested-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> based on discussion here:
> https://lore.kernel.org/all/CAL_JsqK_3xxD0DFwipXO85P=q=EYjUdjE1_8g1MKtvw3vVzx5A@mail.gmail.com/
> https://lore.kernel.org/all/CAL_JsqJSi=kJSix=f3787ULZnaCy_Y26Phdhy5y9fat_vkDuUw@mail.gmail.com/
> ---
>  arch/arm64/boot/dts/mediatek/Makefile | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
> index c99c3372a4b5..18be027bf6b4 100644
> --- a/arch/arm64/boot/dts/mediatek/Makefile
> +++ b/arch/arm64/boot/dts/mediatek/Makefile
> @@ -13,6 +13,14 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtbo
>  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo
>  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo
>  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd.dtbo
> +mt7986a-bananapi-bpi-r3-emmc-nand-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-emmc.dtbo mt7986a-bananapi-bpi-r3-nand.dtbo
> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nand.dtb
> +mt7986a-bananapi-bpi-r3-emmc-nor-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-emmc.dtbo mt7986a-bananapi-bpi-r3-nor.dtbo
> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nor.dtb
> +mt7986a-bananapi-bpi-r3-sd-nand-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-sd.dtbo mt7986a-bananapi-bpi-r3-nand.dtbo
> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nand.dtb
> +mt7986a-bananapi-bpi-r3-sd-nor-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-sd.dtbo mt7986a-bananapi-bpi-r3-nor.dtbo
> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nor.dtb
>  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-rfb.dtb
>  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986b-rfb.dtb
>  dtb-$(CONFIG_ARCH_MEDIATEK) += mt8167-pumpkin.dtb
> --
> 2.34.1
>
>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Aw: [RFC v1] arm64: dts: mediatek: add dtbs with applied overlays for bpi-r3
  2023-09-30 12:57 ` Aw: " Frank Wunderlich
@ 2023-10-23 11:59   ` Frank Wunderlich
  2023-10-23 13:25     ` Krzysztof Kozlowski
  2023-10-25 13:10   ` Frank Wunderlich
  1 sibling, 1 reply; 7+ messages in thread
From: Frank Wunderlich @ 2023-10-23 11:59 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski
  Cc: linux-mediatek, Matthias Brugger, AngeloGioacchino Del Regno,
	Conor Dooley, linux-kernel, linux-arm-kernel, Frank Wunderlich,
	Rob Herring, Frank Wunderlich

Hi Rob/Krzysztof

can you please give an Ack or tell me if something is wrong?

regards Frank


> Gesendet: Samstag, 30. September 2023 um 14:57 Uhr
> Von: "Frank Wunderlich" <frank-w@public-files.de>
> An: "Rob Herring" <robh+dt@kernel.org>
> Cc: linux-mediatek@lists.infradead.org, "Matthias Brugger" <matthias.bgg@gmail.com>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Conor Dooley" <conor+dt@kernel.org>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Frank Wunderlich" <linux@fw-web.de>
> Betreff: Aw: [RFC v1] arm64: dts: mediatek: add dtbs with applied overlays for bpi-r3
>
> Hi,
>
> just a friendly reminder...is this the right way to go?
>
> regards Frank
>
>
> > Gesendet: Samstag, 16. September 2023 um 10:32 Uhr
> > Von: "Frank Wunderlich" <linux@fw-web.de>
> > An: linux-mediatek@lists.infradead.org
> > Cc: "Frank Wunderlich" <frank-w@public-files.de>, "Matthias Brugger" <matthias.bgg@gmail.com>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Conor Dooley" <conor+dt@kernel.org>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
> > Betreff: [RFC v1] arm64: dts: mediatek: add dtbs with applied overlays for bpi-r3
> >
> > From: Frank Wunderlich <frank-w@public-files.de>
> >
> > Build devicetree binaries for testing overlays and providing users
> > full dtb without using overlays.
> >
> > Suggested-by: Rob Herring <robh+dt@kernel.org>
> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> > ---
> > based on discussion here:
> > https://lore.kernel.org/all/CAL_JsqK_3xxD0DFwipXO85P=q=EYjUdjE1_8g1MKtvw3vVzx5A@mail.gmail.com/
> > https://lore.kernel.org/all/CAL_JsqJSi=kJSix=f3787ULZnaCy_Y26Phdhy5y9fat_vkDuUw@mail.gmail.com/
> > ---
> >  arch/arm64/boot/dts/mediatek/Makefile | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
> > index c99c3372a4b5..18be027bf6b4 100644
> > --- a/arch/arm64/boot/dts/mediatek/Makefile
> > +++ b/arch/arm64/boot/dts/mediatek/Makefile
> > @@ -13,6 +13,14 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtbo
> >  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo
> >  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo
> >  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd.dtbo
> > +mt7986a-bananapi-bpi-r3-emmc-nand-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-emmc.dtbo mt7986a-bananapi-bpi-r3-nand.dtbo
> > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nand.dtb
> > +mt7986a-bananapi-bpi-r3-emmc-nor-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-emmc.dtbo mt7986a-bananapi-bpi-r3-nor.dtbo
> > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nor.dtb
> > +mt7986a-bananapi-bpi-r3-sd-nand-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-sd.dtbo mt7986a-bananapi-bpi-r3-nand.dtbo
> > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nand.dtb
> > +mt7986a-bananapi-bpi-r3-sd-nor-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-sd.dtbo mt7986a-bananapi-bpi-r3-nor.dtbo
> > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nor.dtb
> >  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-rfb.dtb
> >  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986b-rfb.dtb
> >  dtb-$(CONFIG_ARCH_MEDIATEK) += mt8167-pumpkin.dtb
> > --
> > 2.34.1
> >
> >

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Aw: [RFC v1] arm64: dts: mediatek: add dtbs with applied overlays for bpi-r3
  2023-10-23 11:59   ` Frank Wunderlich
@ 2023-10-23 13:25     ` Krzysztof Kozlowski
  2023-10-23 13:36       ` Frank Wunderlich
  0 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-10-23 13:25 UTC (permalink / raw)
  To: Frank Wunderlich, Rob Herring, Krzysztof Kozlowski
  Cc: linux-mediatek, Matthias Brugger, AngeloGioacchino Del Regno,
	Conor Dooley, linux-kernel, linux-arm-kernel, Frank Wunderlich

On 23/10/2023 13:59, Frank Wunderlich wrote:
> Hi Rob/Krzysztof
> 
> can you please give an Ack or tell me if something is wrong?

Hm? I do not recall being the maintainer of Mediatek. Why do you need an
Ack from me?

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Aw: [RFC v1] arm64: dts: mediatek: add dtbs with applied overlays for bpi-r3
  2023-10-23 13:25     ` Krzysztof Kozlowski
@ 2023-10-23 13:36       ` Frank Wunderlich
  2023-10-23 13:45         ` Krzysztof Kozlowski
  0 siblings, 1 reply; 7+ messages in thread
From: Frank Wunderlich @ 2023-10-23 13:36 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski
  Cc: linux-mediatek, Matthias Brugger, AngeloGioacchino Del Regno,
	Conor Dooley, linux-kernel, linux-arm-kernel, Frank Wunderlich

Am 23. Oktober 2023 15:25:27 MESZ schrieb Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>:
>On 23/10/2023 13:59, Frank Wunderlich wrote:
>> Hi Rob/Krzysztof
>> 
>> can you please give an Ack or tell me if something is wrong?
>
>Hm? I do not recall being the maintainer of Mediatek. Why do you need an
>Ack from me?
>
>Best regards,
>Krzysztof
>

I asked you because rob suggested the fix,but does not confirm i have done it right. I guess you have same role,or am i wrong here (sorry then)?

If no ack is needed, then mtk maintainer can apply it to solve the problem rob reports? So then we can continue with additional dts changes
regards Frank

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Aw: [RFC v1] arm64: dts: mediatek: add dtbs with applied overlays for bpi-r3
  2023-10-23 13:36       ` Frank Wunderlich
@ 2023-10-23 13:45         ` Krzysztof Kozlowski
  0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-10-23 13:45 UTC (permalink / raw)
  To: frank-w, Rob Herring, Krzysztof Kozlowski
  Cc: linux-mediatek, Matthias Brugger, AngeloGioacchino Del Regno,
	Conor Dooley, linux-kernel, linux-arm-kernel, Frank Wunderlich

On 23/10/2023 15:36, Frank Wunderlich wrote:
> Am 23. Oktober 2023 15:25:27 MESZ schrieb Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>:
>> On 23/10/2023 13:59, Frank Wunderlich wrote:
>>> Hi Rob/Krzysztof
>>>
>>> can you please give an Ack or tell me if something is wrong?
>>
>> Hm? I do not recall being the maintainer of Mediatek. Why do you need an
>> Ack from me?
>>
>> Best regards,
>> Krzysztof
>>
> 
> I asked you because rob suggested the fix,but does not confirm i have done it right. I guess you have same role,or am i wrong here (sorry then)?
> 
> If no ack is needed, then mtk maintainer can apply it to solve the problem rob reports? So then we can continue with additional dts changes

There is no requirement from a reporter/suggester to confirm your fix.
Just like with every patch, anyone is welcomed to review, so pinging
specific non-mandatory reviewer is rather noise in our mailboxes.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Aw: [RFC v1] arm64: dts: mediatek: add dtbs with applied overlays for bpi-r3
  2023-09-30 12:57 ` Aw: " Frank Wunderlich
  2023-10-23 11:59   ` Frank Wunderlich
@ 2023-10-25 13:10   ` Frank Wunderlich
  1 sibling, 0 replies; 7+ messages in thread
From: Frank Wunderlich @ 2023-10-25 13:10 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: Rob Herring, linux-mediatek, Matthias Brugger,
	Krzysztof Kozlowski, Conor Dooley, linux-kernel, linux-arm-kernel,
	Frank Wunderlich, Frank Wunderlich

Hi

thinked a bit again on this Patch as i try to summarize sent patches
in 1 series to make it easier for maintainer to pick up.

> > Gesendet: Samstag, 16. September 2023 um 10:32 Uhr
> > Von: "Frank Wunderlich" <linux@fw-web.de>
> > An: linux-mediatek@lists.infradead.org
> > Cc: "Frank Wunderlich" <frank-w@public-files.de>, "Matthias Brugger" <matthias.bgg@gmail.com>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Conor Dooley" <conor+dt@kernel.org>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
> > Betreff: [RFC v1] arm64: dts: mediatek: add dtbs with applied overlays for bpi-r3
> >
> > From: Frank Wunderlich <frank-w@public-files.de>
> >
> > Build devicetree binaries for testing overlays and providing users
> > full dtb without using overlays.
> >
> > Suggested-by: Rob Herring <robh+dt@kernel.org>
> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> > ---
> > based on discussion here:
> > https://lore.kernel.org/all/CAL_JsqK_3xxD0DFwipXO85P=q=EYjUdjE1_8g1MKtvw3vVzx5A@mail.gmail.com/
> > https://lore.kernel.org/all/CAL_JsqJSi=kJSix=f3787ULZnaCy_Y26Phdhy5y9fat_vkDuUw@mail.gmail.com/
> > ---
> >  arch/arm64/boot/dts/mediatek/Makefile | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
> > index c99c3372a4b5..18be027bf6b4 100644
> > --- a/arch/arm64/boot/dts/mediatek/Makefile
> > +++ b/arch/arm64/boot/dts/mediatek/Makefile
> > @@ -13,6 +13,14 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtbo
> >  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo
> >  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo
> >  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd.dtbo
> > +mt7986a-bananapi-bpi-r3-emmc-nand-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-emmc.dtbo mt7986a-bananapi-bpi-r3-nand.dtbo
> > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nand.dtb
> > +mt7986a-bananapi-bpi-r3-emmc-nor-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-emmc.dtbo mt7986a-bananapi-bpi-r3-nor.dtbo
> > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nor.dtb
> > +mt7986a-bananapi-bpi-r3-sd-nand-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-sd.dtbo mt7986a-bananapi-bpi-r3-nand.dtbo
> > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nand.dtb
> > +mt7986a-bananapi-bpi-r3-sd-nor-dtbs := mt7986a-bananapi-bpi-r3.dtb mt7986a-bananapi-bpi-r3-sd.dtbo mt7986a-bananapi-bpi-r3-nor.dtbo

maybe this is nicer?

mt7986a-bananapi-bpi-r3-emmc-nand-dtbs := mt7986a-bananapi-bpi-r3.dtb \
					  mt7986a-bananapi-bpi-r3-emmc.dtbo \
					  mt7986a-bananapi-bpi-r3-nand.dtbo
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nand.dtb
mt7986a-bananapi-bpi-r3-emmc-nor-dtbs := mt7986a-bananapi-bpi-r3.dtb \
					 mt7986a-bananapi-bpi-r3-emmc.dtbo \
					 mt7986a-bananapi-bpi-r3-nor.dtbo
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nor.dtb
mt7986a-bananapi-bpi-r3-sd-nand-dtbs := mt7986a-bananapi-bpi-r3.dtb \
					mt7986a-bananapi-bpi-r3-sd.dtbo \
					mt7986a-bananapi-bpi-r3-nand.dtbo
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nand.dtb
mt7986a-bananapi-bpi-r3-sd-nor-dtbs := mt7986a-bananapi-bpi-r3.dtb \
				       mt7986a-bananapi-bpi-r3-sd.dtbo \
				       mt7986a-bananapi-bpi-r3-nor.dtbo
dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nor.dtb

here i tried to align the text on first name, but this results in visible stairs.
maybe only 1 tab to indent here (or anything else)? what do you think? In the end
better readable as 1 long line.

the SATA-Patch [1] will then add a line to each of the 4 blocks here (+5 lines in total except changes by adding the backslash).

> > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nor.dtb
> >  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-rfb.dtb
> >  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986b-rfb.dtb
> >  dtb-$(CONFIG_ARCH_MEDIATEK) += mt8167-pumpkin.dtb
> > --
> > 2.34.1
> >

regards Frank

[1] https://patchwork.kernel.org/project/linux-mediatek/patch/20230901072730.13571-1-linux@fw-web.de/

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-10-25 13:10 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-16  8:32 [RFC v1] arm64: dts: mediatek: add dtbs with applied overlays for bpi-r3 Frank Wunderlich
2023-09-30 12:57 ` Aw: " Frank Wunderlich
2023-10-23 11:59   ` Frank Wunderlich
2023-10-23 13:25     ` Krzysztof Kozlowski
2023-10-23 13:36       ` Frank Wunderlich
2023-10-23 13:45         ` Krzysztof Kozlowski
2023-10-25 13:10   ` Frank Wunderlich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox