From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9628ECD37B2 for ; Sat, 16 Sep 2023 06:20:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238720AbjIPGTd (ORCPT ); Sat, 16 Sep 2023 02:19:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238785AbjIPGT2 (ORCPT ); Sat, 16 Sep 2023 02:19:28 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 866FDCC0; Fri, 15 Sep 2023 23:19:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694845163; x=1726381163; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Z/4bikEkIU7qMbozJqqn90Ffha07LnMM+FA07DYflPw=; b=Y7tqwcSoVqiWEXI/HEiNdnjbjWrXsuoS9Y8sx6ICb2fBHAk7SzYfdE17 LaPrRgo09TttLfAP5Nl/1HGJqGZIxOyCtfk7mEhSHsjlS/yMj6HoBs1Li j2l8HF+0Z2cyYIIrfeOwTBrNGQPYiOyuU9erz0w/zulxXz+Ax/xJXdPJN 4qnDvutNd3+G+WF1muIXerM1mAteQcrmkNucuON31XJOlX9HUsGhTloRa Ylqly24Cvvq3vKyKYyeNV+PGvDJJGBhXPc62usP3Vkvv2RJndokVkZS2w M1oxXsthgoBNAXHBIoIUbX6XBZx91sJr2rPrlmWIF/EDjoXeXidQOgML0 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10834"; a="379303509" X-IronPort-AV: E=Sophos;i="6.02,151,1688454000"; d="scan'208";a="379303509" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2023 23:19:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10834"; a="748424258" X-IronPort-AV: E=Sophos;i="6.02,151,1688454000"; d="scan'208";a="748424258" Received: from lkp-server02.sh.intel.com (HELO 9ef86b2655e5) ([10.239.97.151]) by fmsmga007.fm.intel.com with ESMTP; 15 Sep 2023 23:19:20 -0700 Received: from kbuild by 9ef86b2655e5 with local (Exim 4.96) (envelope-from ) id 1qhOeE-0003xU-0i; Sat, 16 Sep 2023 06:19:18 +0000 Date: Sat, 16 Sep 2023 14:18:28 +0800 From: kernel test robot To: Ma Ke , jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ma Ke Subject: Re: [PATCH] net: sched: drr: dont intepret cls results when asked to drop Message-ID: <202309161334.0j3RBkmV-lkp@intel.com> References: <20230915142056.3411330-1-make_ruc2021@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230915142056.3411330-1-make_ruc2021@163.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ma, kernel test robot noticed the following build errors: [auto build test ERROR on net-next/main] [also build test ERROR on net/main linus/master v6.6-rc1 next-20230915] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Ma-Ke/net-sched-drr-dont-intepret-cls-results-when-asked-to-drop/20230915-223913 base: net-next/main patch link: https://lore.kernel.org/r/20230915142056.3411330-1-make_ruc2021%40163.com patch subject: [PATCH] net: sched: drr: dont intepret cls results when asked to drop config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20230916/202309161334.0j3RBkmV-lkp@intel.com/config) compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230916/202309161334.0j3RBkmV-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202309161334.0j3RBkmV-lkp@intel.com/ All errors (new ones prefixed by >>): >> net/sched/sch_drr.c:321:4: error: fallthrough annotation does not directly precede switch label fallthrough; ^ include/linux/compiler_attributes.h:227:41: note: expanded from macro 'fallthrough' # define fallthrough __attribute__((__fallthrough__)) ^ 1 error generated. vim +321 net/sched/sch_drr.c 13d2a1d2b032de Patrick McHardy 2008-11-20 293 13d2a1d2b032de Patrick McHardy 2008-11-20 294 static struct drr_class *drr_classify(struct sk_buff *skb, struct Qdisc *sch, 13d2a1d2b032de Patrick McHardy 2008-11-20 295 int *qerr) 13d2a1d2b032de Patrick McHardy 2008-11-20 296 { 13d2a1d2b032de Patrick McHardy 2008-11-20 297 struct drr_sched *q = qdisc_priv(sch); 13d2a1d2b032de Patrick McHardy 2008-11-20 298 struct drr_class *cl; 13d2a1d2b032de Patrick McHardy 2008-11-20 299 struct tcf_result res; 25d8c0d55f241c John Fastabend 2014-09-12 300 struct tcf_proto *fl; 13d2a1d2b032de Patrick McHardy 2008-11-20 301 int result; 13d2a1d2b032de Patrick McHardy 2008-11-20 302 13d2a1d2b032de Patrick McHardy 2008-11-20 303 if (TC_H_MAJ(skb->priority ^ sch->handle) == 0) { 13d2a1d2b032de Patrick McHardy 2008-11-20 304 cl = drr_find_class(sch, skb->priority); 13d2a1d2b032de Patrick McHardy 2008-11-20 305 if (cl != NULL) 13d2a1d2b032de Patrick McHardy 2008-11-20 306 return cl; 13d2a1d2b032de Patrick McHardy 2008-11-20 307 } 13d2a1d2b032de Patrick McHardy 2008-11-20 308 13d2a1d2b032de Patrick McHardy 2008-11-20 309 *qerr = NET_XMIT_SUCCESS | __NET_XMIT_BYPASS; 25d8c0d55f241c John Fastabend 2014-09-12 310 fl = rcu_dereference_bh(q->filter_list); 3aa2605594556c Davide Caratti 2021-07-28 311 result = tcf_classify(skb, NULL, fl, &res, false); 13d2a1d2b032de Patrick McHardy 2008-11-20 312 if (result >= 0) { 13abeaf39ca823 Ma Ke 2023-09-15 313 if (result == TC_ACT_SHOT) 13abeaf39ca823 Ma Ke 2023-09-15 314 return NULL; 13d2a1d2b032de Patrick McHardy 2008-11-20 315 #ifdef CONFIG_NET_CLS_ACT 13d2a1d2b032de Patrick McHardy 2008-11-20 316 switch (result) { 13d2a1d2b032de Patrick McHardy 2008-11-20 317 case TC_ACT_QUEUED: 13d2a1d2b032de Patrick McHardy 2008-11-20 318 case TC_ACT_STOLEN: e25ea21ffa66a0 Jiri Pirko 2017-06-06 319 case TC_ACT_TRAP: 13d2a1d2b032de Patrick McHardy 2008-11-20 320 *qerr = NET_XMIT_SUCCESS | __NET_XMIT_STOLEN; 964201de695b8a Gustavo A. R. Silva 2020-07-07 @321 fallthrough; 13d2a1d2b032de Patrick McHardy 2008-11-20 322 } 13d2a1d2b032de Patrick McHardy 2008-11-20 323 #endif 13d2a1d2b032de Patrick McHardy 2008-11-20 324 cl = (struct drr_class *)res.class; 13d2a1d2b032de Patrick McHardy 2008-11-20 325 if (cl == NULL) 13d2a1d2b032de Patrick McHardy 2008-11-20 326 cl = drr_find_class(sch, res.classid); 13d2a1d2b032de Patrick McHardy 2008-11-20 327 return cl; 13d2a1d2b032de Patrick McHardy 2008-11-20 328 } 13d2a1d2b032de Patrick McHardy 2008-11-20 329 return NULL; 13d2a1d2b032de Patrick McHardy 2008-11-20 330 } 13d2a1d2b032de Patrick McHardy 2008-11-20 331 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki