From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABDCDC46CA1 for ; Sun, 17 Sep 2023 03:08:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231942AbjIQDIX (ORCPT ); Sat, 16 Sep 2023 23:08:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbjIQDHt (ORCPT ); Sat, 16 Sep 2023 23:07:49 -0400 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4A0E11BC; Sat, 16 Sep 2023 20:07:43 -0700 (PDT) Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 38H37Xt0009951; Sun, 17 Sep 2023 05:07:33 +0200 Date: Sun, 17 Sep 2023 05:07:33 +0200 From: Willy Tarreau To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Shuah Khan , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 4/4] tools/nolibc: automatically detect necessity to use pselect6 Message-ID: <20230917030733.GG9646@1wt.eu> References: <20230914-nolibc-syscall-nr-v1-0-e50df410da11@weissschuh.net> <20230914-nolibc-syscall-nr-v1-4-e50df410da11@weissschuh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230914-nolibc-syscall-nr-v1-4-e50df410da11@weissschuh.net> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 14, 2023 at 06:01:20PM +0200, Thomas Weißschuh wrote: > We can automatically detect if pselect6 is needed or not from the kernel > headers. This removes the need to manually specify it. > > Signed-off-by: Thomas Weißschuh That's indeed cleaner, I can't find the reason why we didn't do it like this initially, I suspect that maybe we were having __NR_select defined but not usable, I don't know. I've found it first introduced with nolibc commit 28a7178 ("nolibc: fall back to pselect6() on aarch64"), and the test was made before __NR_newselect, so maybe I wanted to be sure not to use pselect6() in case another arch would define it. Let's do as you propose, it's much cleaner and simpler. If we ever find any breakage at least we'll know how to deal with it so I'm not worried. Acked-by: Willy Tarreau Thanks! Willy