From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDF96CD37B3 for ; Sun, 17 Sep 2023 03:23:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231321AbjIQDWq (ORCPT ); Sat, 16 Sep 2023 23:22:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229805AbjIQDWn (ORCPT ); Sat, 16 Sep 2023 23:22:43 -0400 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 88891CC8; Sat, 16 Sep 2023 20:22:36 -0700 (PDT) Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 38H3MJrr010050; Sun, 17 Sep 2023 05:22:19 +0200 Date: Sun, 17 Sep 2023 05:22:19 +0200 From: Willy Tarreau To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Masahiro Yamada , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Shuah Khan , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH RFC 0/3] selftests/nolibc: avoid spurious kernel relinks Message-ID: <20230917032219.GH9646@1wt.eu> References: <20230916-nolibc-initramfs-v1-0-4416ecedca6d@weissschuh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230916-nolibc-initramfs-v1-0-4416ecedca6d@weissschuh.net> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 16, 2023 at 09:13:26AM +0200, Thomas Weißschuh wrote: > Currently the nolibc testsuite embeds the test executable into a kernel > image with CONFIG_INITRAMFS_SOURCE. > This forces a full kernel relink everytime the test executable is > updated. > > This relinking step dominates the test cycle. > It is slower than building and running the test in qemu together. > > With a bit of Makefile-shuffling the relinking can be avoided. That's pretty nice as indeed it still takes a while to relink it into the kernel. I agree that for running nolibc-test in qemu we don't need a unified image. However I've seldom used it on real hardware and I find it significantly more convenient to use as a single image in this case. Maybe we should just rename targets so that everything qemu-related just uses two distinct images while a "unified-image" (or anything else) still assembles the image into the kernel (BTW the help on the "kernel" target still mentions initramfs). Note that we don't need to modify anything in the build system to create an initrd, I usually make them by hand using "cpio -o -H newc", we don't need anything else here. Regarding rerun, I'd rather keep it for the sole reason that I've used it to check for randomly failing errors (typically the timing-based ones). It's convenient to run the same image 100 times if needed. I'm not strongly attached to it, but if "make run" is slower, then we can keep it. However if you really want to drop it, it also needs to be dropped from the help message ;-) Cheers, Willy