From: Piro Yang <piroyangg@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Piro Yang <piroyangg@gmail.com>
Subject: [PATCH] staging: vme_user: Fixed prink formatting issues
Date: Mon, 18 Sep 2023 01:18:24 +0800 [thread overview]
Message-ID: <20230917171824.76702-1-piroyangg@gmail.com> (raw)
Fixed issues relating to prink message including:
a. using __func__ to replace function's name
b. using pr_warn to replace "printk(KERN_ERR"
Issue found by checkpatch
Signed-off-by: Piro Yang <piroyangg@gmail.com>
---
drivers/staging/vme_user/vme.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c
index 5960562dcd96..56c528628e7d 100644
--- a/drivers/staging/vme_user/vme.c
+++ b/drivers/staging/vme_user/vme.c
@@ -418,7 +418,7 @@ int vme_slave_get(struct vme_resource *resource, int *enabled,
image = list_entry(resource->entry, struct vme_slave_resource, list);
if (!bridge->slave_get) {
- printk(KERN_ERR "vme_slave_get not supported\n");
+ pr_warn("%s not supported\n", __func__);
return -EINVAL;
}
@@ -568,7 +568,7 @@ int vme_master_set(struct vme_resource *resource, int enabled,
image = list_entry(resource->entry, struct vme_master_resource, list);
if (!bridge->master_set) {
- printk(KERN_WARNING "vme_master_set not supported\n");
+ pr_warn("%s not supported\n", __func__);
return -EINVAL;
}
@@ -618,7 +618,7 @@ int vme_master_get(struct vme_resource *resource, int *enabled,
image = list_entry(resource->entry, struct vme_master_resource, list);
if (!bridge->master_get) {
- printk(KERN_WARNING "%s not supported\n", __func__);
+ pr_warn("%s not supported\n", __func__);
return -EINVAL;
}
@@ -1552,7 +1552,7 @@ int vme_lm_set(struct vme_resource *resource, unsigned long long lm_base,
lm = list_entry(resource->entry, struct vme_lm_resource, list);
if (!bridge->lm_set) {
- printk(KERN_ERR "vme_lm_set not supported\n");
+ pr_warn("%s not supported\n", __func__);
return -EINVAL;
}
@@ -1588,7 +1588,7 @@ int vme_lm_get(struct vme_resource *resource, unsigned long long *lm_base,
lm = list_entry(resource->entry, struct vme_lm_resource, list);
if (!bridge->lm_get) {
- printk(KERN_ERR "vme_lm_get not supported\n");
+ printk(KERN_ERR "%s not supported\n", __func__);
return -EINVAL;
}
@@ -1625,7 +1625,7 @@ int vme_lm_attach(struct vme_resource *resource, int monitor,
lm = list_entry(resource->entry, struct vme_lm_resource, list);
if (!bridge->lm_attach) {
- printk(KERN_ERR "vme_lm_attach not supported\n");
+ printk(KERN_ERR "%s not supported\n", __func__);
return -EINVAL;
}
@@ -1658,7 +1658,7 @@ int vme_lm_detach(struct vme_resource *resource, int monitor)
lm = list_entry(resource->entry, struct vme_lm_resource, list);
if (!bridge->lm_detach) {
- printk(KERN_ERR "vme_lm_detach not supported\n");
+ printk(KERN_ERR "%s not supported\n", __func__);
return -EINVAL;
}
@@ -1725,7 +1725,7 @@ int vme_slot_num(struct vme_dev *vdev)
}
if (!bridge->slot_get) {
- printk(KERN_WARNING "vme_slot_num not supported\n");
+ printk(KERN_WARNING "%s not supported\n", __func__);
return -EINVAL;
}
--
2.25.1
next reply other threads:[~2023-09-17 17:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-17 17:18 Piro Yang [this message]
2023-09-17 18:11 ` [RESEND PATCH] staging: vme_user: Fixed prink formatting issues Piro Yang
2023-09-17 18:33 ` Greg KH
2023-09-17 18:34 ` [PATCH] " Greg KH
2023-09-17 19:23 ` [PATCH v2] staging: vme_user: Fixed prink formatting issue Piro Yang
2023-09-17 19:32 ` Greg KH
2023-09-17 19:47 ` Philipp Hortmann
2023-09-17 20:30 ` [PATCH v2] staging: vme_user: using __func__ to replace function's name in printk Piro Yang
2023-09-26 9:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230917171824.76702-1-piroyangg@gmail.com \
--to=piroyangg@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox