From: Greg KH <gregkh@linuxfoundation.org>
To: Piro Yang <piroyangg@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vme_user: Fixed prink formatting issues
Date: Sun, 17 Sep 2023 20:34:37 +0200 [thread overview]
Message-ID: <2023091756-duct-agile-0023@gregkh> (raw)
In-Reply-To: <20230917171824.76702-1-piroyangg@gmail.com>
On Mon, Sep 18, 2023 at 01:18:24AM +0800, Piro Yang wrote:
> Fixed issues relating to prink message including:
>
> a. using __func__ to replace function's name
> b. using pr_warn to replace "printk(KERN_ERR"
>
> Issue found by checkpatch
>
> Signed-off-by: Piro Yang <piroyangg@gmail.com>
> ---
> drivers/staging/vme_user/vme.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c
> index 5960562dcd96..56c528628e7d 100644
> --- a/drivers/staging/vme_user/vme.c
> +++ b/drivers/staging/vme_user/vme.c
> @@ -418,7 +418,7 @@ int vme_slave_get(struct vme_resource *resource, int *enabled,
> image = list_entry(resource->entry, struct vme_slave_resource, list);
>
> if (!bridge->slave_get) {
> - printk(KERN_ERR "vme_slave_get not supported\n");
> + pr_warn("%s not supported\n", __func__);
KERN_ERR is not the same thing a pr_warn(), why did you make this
change?
And you are doing multiple things in the same change, why?
Also, drivers should always use dev_warn(), not pr_*() calls.
thanks,
greg k-h
next prev parent reply other threads:[~2023-09-17 18:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-17 17:18 [PATCH] staging: vme_user: Fixed prink formatting issues Piro Yang
2023-09-17 18:11 ` [RESEND PATCH] " Piro Yang
2023-09-17 18:33 ` Greg KH
2023-09-17 18:34 ` Greg KH [this message]
2023-09-17 19:23 ` [PATCH v2] staging: vme_user: Fixed prink formatting issue Piro Yang
2023-09-17 19:32 ` Greg KH
2023-09-17 19:47 ` Philipp Hortmann
2023-09-17 20:30 ` [PATCH v2] staging: vme_user: using __func__ to replace function's name in printk Piro Yang
2023-09-26 9:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023091756-duct-agile-0023@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=piroyangg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox