From: Alex Williamson <alex.williamson@redhat.com>
To: oushixiong <oushixiong@kylinos.cn>
Cc: Jason Gunthorpe <jgg@ziepe.ca>, Yishai Hadas <yishaih@nvidia.com>,
Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
Kevin Tian <kevin.tian@intel.com>,
Brett Creeley <brett.creeley@amd.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio/pds: Add missing PCI_IOV depends
Date: Mon, 18 Sep 2023 14:51:11 -0600 [thread overview]
Message-ID: <20230918145111.6473b148.alex.williamson@redhat.com> (raw)
In-Reply-To: <20230906014942.1658769-1-oushixiong@kylinos.cn>
On Wed, 6 Sep 2023 09:49:42 +0800
oushixiong <oushixiong@kylinos.cn> wrote:
> From: Shixiong Ou <oushixiong@kylinos.cn>
>
> If PCI_ATS isn't set, then pdev->physfn is not defined.
> it causes a compilation issue:
>
> ../drivers/vfio/pci/pds/vfio_dev.c:165:30: error: ‘struct pci_dev’ has no member named ‘physfn’; did you mean ‘is_physfn’?
> 165 | __func__, pci_dev_id(pdev->physfn), pci_id, vf_id,
> | ^~~~~~
>
> So adding PCI_IOV depends to select PCI_ATS.
>
> Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn>
> ---
> drivers/vfio/pci/pds/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to vfio for-linus branch for v6.6. Thanks,
Alex
>
> diff --git a/drivers/vfio/pci/pds/Kconfig b/drivers/vfio/pci/pds/Kconfig
> index 407b3fd32733..6eceef7b028a 100644
> --- a/drivers/vfio/pci/pds/Kconfig
> +++ b/drivers/vfio/pci/pds/Kconfig
> @@ -3,7 +3,7 @@
>
> config PDS_VFIO_PCI
> tristate "VFIO support for PDS PCI devices"
> - depends on PDS_CORE
> + depends on PDS_CORE && PCI_IOV
> select VFIO_PCI_CORE
> help
> This provides generic PCI support for PDS devices using the VFIO
prev parent reply other threads:[~2023-09-18 20:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 1:49 [PATCH] vfio/pds: Add missing PCI_IOV depends oushixiong
2023-09-07 16:20 ` Jason Gunthorpe
2023-09-07 16:25 ` Brett Creeley
2023-09-11 7:08 ` Tian, Kevin
2023-09-18 20:51 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230918145111.6473b148.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=brett.creeley@amd.com \
--cc=jgg@ziepe.ca \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oushixiong@kylinos.cn \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox