From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57BF5CD13D9 for ; Mon, 18 Sep 2023 13:00:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235425AbjIRNAU (ORCPT ); Mon, 18 Sep 2023 09:00:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242040AbjIRM7r (ORCPT ); Mon, 18 Sep 2023 08:59:47 -0400 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::223]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCCD1CD0 for ; Mon, 18 Sep 2023 05:58:56 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 4B5066000A; Mon, 18 Sep 2023 12:58:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1695041935; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oBXbmgI35Ay6iC6gwJK7LAKP2TjFS8/WQ3+OgmLbkxg=; b=eASqEhaQOxhMM0xv2JXtw7MYTf+HDpkUT/wk/+Zw2osl+qMPMkyzZBuIU/fQz2sxzOFFSB vw4pHo8+omK/W7OCuTiynmHRBXCLA2eMtZfsYVqWBApHNzFR2eRmnwhvaX37om4kZn18zp do4bZYwXanFr193bP8khG3YKXG/pTESP37eRX1wXmvHal4iM3Ykk1o4j/N9Mo0bi2Ipm7q 0VjUEYkxTRTCcSSfqyB6/oLkoRiTTsQsIOTdNp6cPG+2/bla76DLjprJUCfuQTFUHWovy3 shQNTgXsLQz2Z5H5lLacO45iqlp4Zs3Se/sMmIeDLp9NuM+6Ydv/h8zDyiaQmQ== Date: Mon, 18 Sep 2023 14:58:52 +0200 From: Miquel Raynal To: Nikita Shubin via B4 Relay Cc: , Richard Weinberger , Vignesh Raghavendra , Arnd Bergmann , Neil Armstrong , Florian Fainelli , Liang Yang , Christophe Kerello , Jean Delvare , Johan Jonker , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Alexander Sverdlin Subject: Re: [PATCH v4 26/42] mtd: nand: add support for ts72xx Message-ID: <20230918145852.46a15c77@xps-13> In-Reply-To: <20230915-ep93xx-v4-26-a1d779dcec10@maquefel.me> References: <20230915-ep93xx-v4-0-a1d779dcec10@maquefel.me> <20230915-ep93xx-v4-26-a1d779dcec10@maquefel.me> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nikita, devnull+nikita.shubin.maquefel.me@kernel.org wrote on Fri, 15 Sep 2023 11:11:08 +0300: > From: Nikita Shubin >=20 > Technologic Systems has it's own nand controller implementation in CPLD. I initially agreed to accept a first version of this controller driver with a legacy API because people were apparently under time pressure to get this in. I see it's been a couple of months, so this is not that urgent after all. As the driver is only 166 lines long, I would strongly prefer a very straight ->exec_op() conversion in order to get rid of these ugly direct I/O accesses. Thanks, Miqu=C3=A8l > Signed-off-by: Nikita Shubin > --- > drivers/mtd/nand/raw/Kconfig | 7 + > drivers/mtd/nand/raw/Makefile | 1 + > drivers/mtd/nand/raw/technologic-nand-controller.c | 166 +++++++++++++++= ++++++ > 3 files changed, 174 insertions(+) >=20