From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Michal Simek <michal.simek@amd.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu,
michal.simek@xilinx.com, git@xilinx.com,
Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Parth Gajjar <parth.gajjar@amd.com>,
Rob Herring <robh+dt@kernel.org>,
Sharath Kumar Dasari <sharath.kumar.dasari@xilinx.com>,
Srinivas Neeli <srinivas.neeli@xilinx.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/6] arm64: xilinx: Remove mt25qu512a compatible string from SOM
Date: Mon, 18 Sep 2023 18:01:19 +0300 [thread overview]
Message-ID: <20230918150119.GC16823@pendragon.ideasonboard.com> (raw)
In-Reply-To: <a1e975f5785dfb6eb04e8d5905dcaa7467ccd585.1695040866.git.michal.simek@amd.com>
Hi Michal,
Thank you for the patch.
On Mon, Sep 18, 2023 at 02:41:14PM +0200, Michal Simek wrote:
> mt25qu512a is not documented in DT binding that's why remove it.
How about adding the compatible string to the bindings instead ?
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>
> arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts
> index 157dcb4a27a8..cd5cd7f3b5ce 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts
> @@ -131,7 +131,7 @@ mux {
> &qspi { /* MIO 0-5 - U143 */
> status = "okay";
> spi_flash: flash@0 { /* MT25QU512A */
> - compatible = "mt25qu512a", "jedec,spi-nor"; /* 64MB */
> + compatible = "jedec,spi-nor"; /* 64MB */
> #address-cells = <1>;
> #size-cells = <1>;
> reg = <0>;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2023-09-18 15:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 12:41 [PATCH 0/6] arm64: xilinx: Tune DTSes to remove warnings from make W=1 dtbs Michal Simek
2023-09-18 12:41 ` [PATCH 1/6] arm64: xilinx: Do not use '_' in DT node names Michal Simek
2023-09-18 14:56 ` Laurent Pinchart
2023-09-19 7:47 ` Michal Simek
2023-09-19 7:56 ` Laurent Pinchart
2023-09-18 12:41 ` [PATCH 2/6] arm64: xilinx: Use lower case for partition address Michal Simek
2023-09-18 14:58 ` Laurent Pinchart
2023-09-18 12:41 ` [PATCH 3/6] arm64: xilinx: Remove mt25qu512a compatible string from SOM Michal Simek
2023-09-18 15:01 ` Laurent Pinchart [this message]
2023-09-19 7:06 ` Michal Simek
2023-09-18 12:41 ` [PATCH 4/6] arm64: xilinx: Put ethernet phys to mdio node Michal Simek
2023-09-18 12:41 ` [PATCH 5/6] arm64: xilinx: Remove address/size-cells from flash node Michal Simek
2023-09-18 12:41 ` [PATCH 6/6] arm64: xilinx: Remove address/size-cells from gem nodes Michal Simek
2023-10-16 10:07 ` [PATCH 0/6] arm64: xilinx: Tune DTSes to remove warnings from make W=1 dtbs Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230918150119.GC16823@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=amit.kumar-mahapatra@xilinx.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=parth.gajjar@amd.com \
--cc=robh+dt@kernel.org \
--cc=sharath.kumar.dasari@xilinx.com \
--cc=srinivas.neeli@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox