From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9D28CD54A7 for ; Tue, 19 Sep 2023 08:34:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231714AbjISIev (ORCPT ); Tue, 19 Sep 2023 04:34:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231640AbjISIee (ORCPT ); Tue, 19 Sep 2023 04:34:34 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B6FD125 for ; Tue, 19 Sep 2023 01:34:28 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B93B5C433CC; Tue, 19 Sep 2023 08:34:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1695112468; bh=Rkx4DECD6m48ZZAFf7O2RdRfTlvmBElc9OF73G6+SxU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LYzXJcn1cTuuHOFSB6shJNJQNQha+64MLKjF/iQ3iYcChM0i1xJntutB+T36DBT9K ZfT142D0/21J6DOpPr926O9I/VGLCrdOuWCstHUxThQipjOoCO5nEbVruRNKHcippn Wy+u/LSxGllkVfqem6Nmh97TCrOczL0KYYfwTkhg= Date: Tue, 19 Sep 2023 10:31:30 +0200 From: Greg KH To: Mukesh Ojha Cc: mcgrof@kernel.org, russell.h.weight@intel.com, rafael@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware_loader: Add reboot_in_progress for user helper path Message-ID: <2023091952-amends-animosity-4760@gregkh> References: <1694773288-15755-1-git-send-email-quic_mojha@quicinc.com> <2023091727-clever-schilling-3814@gregkh> <5f4255d1-51e9-8888-c32d-723a6a7afb5d@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5f4255d1-51e9-8888-c32d-723a6a7afb5d@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 19, 2023 at 01:27:05PM +0530, Mukesh Ojha wrote: > > > +bool reboot_in_progress; > > > > Bad global name for a variable in the firmware_loader core. > > bool abort_fw_load_req ?? Use "noun_verb" please for global symbols so it's more obvious where the symbol is, and it's a bit easier to manage the namespace. thanks, greg k-h