From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A25FCE79AB for ; Wed, 20 Sep 2023 09:52:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234194AbjITJxB (ORCPT ); Wed, 20 Sep 2023 05:53:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234133AbjITJw6 (ORCPT ); Wed, 20 Sep 2023 05:52:58 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2408B8F for ; Wed, 20 Sep 2023 02:52:53 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF699C433C8; Wed, 20 Sep 2023 09:52:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695203572; bh=G3+t/AULLWNh/21z8lviL/DfMfnBVEfDFPKXU/x5BUQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JNkLOFC6GBv/DB79y+fdROm7M47768bWI9Vxlr4zTuYfWvtGIHJTrxWRACe/H7vEB nxR1VT8B6Otw+uCW1B118CyHut8SoO1Dh4zrlvJ35qDnebAy2VHDi04+6e6rILtJYr ESrhTYDtDWzVq6ND2MH1yZ1eXbjc6ujEixBCwh4R93wtVzKvE8awExTXHSryPdbf8P DR0hLE35Rt1XM47NWtn9zYU3DJmSvjF554DAIyUbt7+rcVDi5NXejNqYHHIiHy+8Ca QVqo13+B1ycKy+T/xV8Yc6UgXbiaEpc0Z2IdRBno9NXmbiEJDLTnvap24yKuNhEgw/ 5w8EDtuA9XREg== Date: Wed, 20 Sep 2023 10:52:48 +0100 From: Lee Jones To: zhangshida Cc: linux-kernel@vger.kernel.org, zhangshida@kylinos.cn, k2ci Subject: Re: [PATCH] mfd: cs42l43: fix defined but not used warnings Message-ID: <20230920095248.GC13143@google.com> References: <20230905021209.1412987-1-zhangshida@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230905021209.1412987-1-zhangshida@kylinos.cn> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 05 Sep 2023, zhangshida wrote: > From: Shida Zhang > > Warnings were generated during compiling for functions like > cs42l43_*_{resume,suspend}: > > ../drivers/mfd/cs42l43.c:1138:12: error: ‘cs42l43_runtime_resume’ defined but not used [-Werror=unused-function] > 1138 | static int cs42l43_runtime_resume(struct device *dev) > | ^~~~~~~~~~~~~~~~~~~~~~ > ../drivers/mfd/cs42l43.c:1124:12: error: ‘cs42l43_runtime_suspend’ defined but not used [-Werror=unused-function] > 1124 | static int cs42l43_runtime_suspend(struct device *dev) > | ^~~~~~~~~~~~~~~~~~~~~~~ > ../drivers/mfd/cs42l43.c:1106:12: error: ‘cs42l43_resume’ defined but not used [-Werror=unused-function] > 1106 | static int cs42l43_resume(struct device *dev) > | ^~~~~~~~~~~~~~ > ../drivers/mfd/cs42l43.c:1076:12: error: ‘cs42l43_suspend’ defined but not used [-Werror=unused-function] > 1076 | static int cs42l43_suspend(struct device *dev) > > Fix it by guarding it with CONFIG_PM/CONFIG_PM_SLEEP. > > Reported-by: k2ci > Signed-off-by: Shida Zhang > --- > drivers/mfd/cs42l43.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mfd/cs42l43.c b/drivers/mfd/cs42l43.c > index 37b23e9bae82..e589a61c118d 100644 > --- a/drivers/mfd/cs42l43.c > +++ b/drivers/mfd/cs42l43.c > @@ -1073,6 +1073,7 @@ void cs42l43_dev_remove(struct cs42l43 *cs42l43) > } > EXPORT_SYMBOL_NS_GPL(cs42l43_dev_remove, MFD_CS42L43); > > +#ifdef CONFIG_PM_SLEEP > static int cs42l43_suspend(struct device *dev) > { > struct cs42l43 *cs42l43 = dev_get_drvdata(dev); > @@ -1120,7 +1121,9 @@ static int cs42l43_resume(struct device *dev) > > return 0; > } > +#endif > > +#ifdef CONFIG_PM > static int cs42l43_runtime_suspend(struct device *dev) > { > struct cs42l43 *cs42l43 = dev_get_drvdata(dev); > @@ -1176,6 +1179,7 @@ static int cs42l43_runtime_resume(struct device *dev) > > return ret; > } > +#endif > > EXPORT_NS_GPL_DEV_PM_OPS(cs42l43_pm_ops, MFD_CS42L43) = { > SET_SYSTEM_SLEEP_PM_OPS(cs42l43_suspend, cs42l43_resume) I see a bunch of drivers using PM helpers and not many of them are are being guarded by ugly #ifery. Please find out what they're doing to solve the same issue and replicate that instead. Here's a really big hint: `git log --oneline 02313a90095fb` -- Lee Jones [李琼斯]