public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
	linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
	Theodore Ts'o <tytso@mit.edu>,
	Dominik Brodowski <linux@dominikbrodowski.net>,
	Jann Horn <jannh@google.com>
Subject: Re: [RFC] Should writes to /dev/urandom immediately affect reads?
Date: Wed, 20 Sep 2023 13:45:24 -0700	[thread overview]
Message-ID: <20230920204524.GD914@sol.localdomain> (raw)
In-Reply-To: <CAHk-=wgu4a=ckih8+JgfwYPZcp-uvc1Nh2LTGBSzSVKMYRk+-w@mail.gmail.com>

On Wed, Sep 20, 2023 at 01:32:29PM -0700, Linus Torvalds wrote:
> On Wed, 20 Sept 2023 at 13:21, Eric Biggers <ebiggers@kernel.org> wrote:
> >
> > It seems that what you're claiming (in addition to the RNG always being
> > initialized quickly on platforms that are "relevant", whatever that means) is
> > that once the RNG is "initialized", there's no need to reseed it anymore.
> 
> No. You are literally putting words in my mouth that I at no point
> even implied. You're making up an argument.
> 
> I *LITERALLY* am asking a very simple question: WHO DO YOU EVEN CARE
> ABOUT THIS "IMMEDIATE" EFFECT.
> 
> Give me a real reason. Give me *any* reason.
> 
> Don't try to turn this into some other discussion. I'm asking WHY DOES
> ANY OF THIS MATTER?
> 
> The immediacy has changed several times, as you yourself lined up. And
> as far as I can tell, none of this matter in the least.
> 
> > The question is, given that, shouldn't the RNG also reseed right
> > away when userspace explicitly adds something to it
> 
> I don't see that there is any "given" at all.
> 
> We do re-seed regularly. I'm not arguing against that.
> 
> I'm literally arguing against applying random changes without giving
> any actual reason for them.
> 
> Which is why I'm asking "why do you care"? Give em a *reason*. Why
> would a user space write matter at all?
> 
> It was why I also asked about entropy. Because *if* you argue that the
> user-space write contains entropy, then that would be a reason.
> 
> You didn't.
> 
> You argue that the current behavior hasn't been the universal behavior. I agree.
> 
> But considering that we've switched behaviors apparently at least
> three times, and at no point did it make any difference, my argument
> is really that without a *REASON*, why would we switch behavior *four*
> times?
> 
> Is it just "four changes is better than three"?

See my first email where I explained the problems with the current behavior.
Especially the third paragraph.

I'll just wait until Jason has a chance to reply.  This discussion clearly isn't
achieving anything with just us two.

- Eric

  parent reply	other threads:[~2023-09-20 20:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-20  6:06 [RFC] Should writes to /dev/urandom immediately affect reads? Eric Biggers
2023-09-20 18:48 ` Linus Torvalds
2023-09-20 19:32   ` Eric Biggers
2023-09-20 19:42     ` Linus Torvalds
2023-09-20 20:21       ` Eric Biggers
2023-09-20 20:32         ` Linus Torvalds
2023-09-20 20:41           ` Linus Torvalds
2023-09-21 21:57             ` David Laight
2023-09-20 20:45           ` Eric Biggers [this message]
2023-09-20 20:48             ` Linus Torvalds
2023-09-21 13:30               ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230920204524.GD914@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=Jason@zx2c4.com \
    --cc=jannh@google.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox