Re: [PATCH 3/4] dt-bindings: sc16is7xx: add vendor prefix to irda-mode-ports property

Hugo Villeneuve
2023-09-21T23:25:28Z

On Thu, 21 Sep 2023 12:29:13 +0200
m.brock@vanmierlo.com wrote:

> Hugo Villeneuve wrote on 2023-09-20 17:20:
> > --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt
> > +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt
> > @@ -21,8 +21,8 @@ Optional properties:
> > the second cell is used to specify the GPIO polarity:
> > 0 = active high,
> > 1 = active low.
> > -- irda-mode-ports: An array that lists the indices of the port that
> > - should operate in IrDA mode.
> > +- nxp,irda-mode-ports: An array that lists the indices of the port
> > that
> > + should operate in IrDA mode.
> > - nxp,modem-control-line-ports: An array that lists the indices of
> > the port that
>
> Are you sure you want this line removed?

Hi Maarten,
the line "- nxp,modem-control-line-ports..." is not removed, but
because it starts with a dash in the source file, maybe it is confusing
when looking at the patch only?

Hugo.

>
> > should have shared GPIO lines configured as
> > modem control lines.
> > @@ -80,8 +80,8 @@ Optional properties:
> > the second cell is used to specify the GPIO polarity:
> > 0 = active high,
> > 1 = active low.
> > -- irda-mode-ports: An array that lists the indices of the port that
> > - should operate in IrDA mode.
> > +- nxp,irda-mode-ports: An array that lists the indices of the port
> > that
> > + should operate in IrDA mode.
> > - nxp,modem-control-line-ports: An array that lists the indices of
> > the port that
>
> Same here.
>
> > should have shared GPIO lines configured as
> > modem control lines.
>
> Greets,
> Maarten
>
>