Re: [PATCH 3/4] dt-bindings: sc16is7xx: add vendor prefix to irda-mode-ports property

Conor Dooley
2023-09-21T21:04:21Z

[-- Attachment #1: Type: text/plain, Size: 2030 bytes --]

On Wed, Sep 20, 2023 at 11:20:14AM -0400, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>
> The NXP-specific "irda-mode-ports" property lacks a proper vendor
> prefix. Add "nxp," prefix to comply with DT best practises.

Looks like you've made changes to the driver in a way both will work,
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

>
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> ---
> .../devicetree/bindings/serial/nxp,sc16is7xx.txt | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt
> index 1a7e4bff0456..d89815c5c562 100644
> --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt
> +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt
> @@ -21,8 +21,8 @@ Optional properties:
> the second cell is used to specify the GPIO polarity:
> 0 = active high,
> 1 = active low.
> -- irda-mode-ports: An array that lists the indices of the port that
> - should operate in IrDA mode.
> +- nxp,irda-mode-ports: An array that lists the indices of the port that
> + should operate in IrDA mode.
> - nxp,modem-control-line-ports: An array that lists the indices of the port that
> should have shared GPIO lines configured as
> modem control lines.
> @@ -80,8 +80,8 @@ Optional properties:
> the second cell is used to specify the GPIO polarity:
> 0 = active high,
> 1 = active low.
> -- irda-mode-ports: An array that lists the indices of the port that
> - should operate in IrDA mode.
> +- nxp,irda-mode-ports: An array that lists the indices of the port that
> + should operate in IrDA mode.
> - nxp,modem-control-line-ports: An array that lists the indices of the port that
> should have shared GPIO lines configured as
> modem control lines.
> --
> 2.30.2
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]