* [PATCH] gcov: Annotate struct gcov_iterator with __counted_by
@ 2023-09-22 17:52 Kees Cook
2023-09-23 16:35 ` Gustavo A. R. Silva
2023-10-05 15:41 ` Peter Oberparleiter
0 siblings, 2 replies; 3+ messages in thread
From: Kees Cook @ 2023-09-22 17:52 UTC (permalink / raw)
To: Peter Oberparleiter
Cc: Kees Cook, Nathan Chancellor, Nick Desaulniers, Tom Rix,
linux-kernel, llvm, linux-hardening
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).
As found with Coccinelle[1], add __counted_by for struct gcov_iterator.
[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
Cc: Peter Oberparleiter <oberpar@linux.ibm.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
---
kernel/gcov/fs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/gcov/fs.c b/kernel/gcov/fs.c
index 5c3086cad8f9..01520689b57c 100644
--- a/kernel/gcov/fs.c
+++ b/kernel/gcov/fs.c
@@ -99,7 +99,7 @@ struct gcov_iterator {
struct gcov_info *info;
size_t size;
loff_t pos;
- char buffer[];
+ char buffer[] __counted_by(size);
};
/**
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] gcov: Annotate struct gcov_iterator with __counted_by
2023-09-22 17:52 [PATCH] gcov: Annotate struct gcov_iterator with __counted_by Kees Cook
@ 2023-09-23 16:35 ` Gustavo A. R. Silva
2023-10-05 15:41 ` Peter Oberparleiter
1 sibling, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2023-09-23 16:35 UTC (permalink / raw)
To: Kees Cook, Peter Oberparleiter
Cc: Nathan Chancellor, Nick Desaulniers, Tom Rix, linux-kernel, llvm,
linux-hardening
On 9/22/23 11:52, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
>
> As found with Coccinelle[1], add __counted_by for struct gcov_iterator.
>
> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
>
> Cc: Peter Oberparleiter <oberpar@linux.ibm.com>
> Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks
--
Gustavo
> ---
> kernel/gcov/fs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/gcov/fs.c b/kernel/gcov/fs.c
> index 5c3086cad8f9..01520689b57c 100644
> --- a/kernel/gcov/fs.c
> +++ b/kernel/gcov/fs.c
> @@ -99,7 +99,7 @@ struct gcov_iterator {
> struct gcov_info *info;
> size_t size;
> loff_t pos;
> - char buffer[];
> + char buffer[] __counted_by(size);
> };
>
> /**
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gcov: Annotate struct gcov_iterator with __counted_by
2023-09-22 17:52 [PATCH] gcov: Annotate struct gcov_iterator with __counted_by Kees Cook
2023-09-23 16:35 ` Gustavo A. R. Silva
@ 2023-10-05 15:41 ` Peter Oberparleiter
1 sibling, 0 replies; 3+ messages in thread
From: Peter Oberparleiter @ 2023-10-05 15:41 UTC (permalink / raw)
To: Kees Cook, Andrew Morton
Cc: Nathan Chancellor, Nick Desaulniers, Tom Rix, linux-kernel, llvm,
linux-hardening
On 22.09.2023 19:52, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
>
> As found with Coccinelle[1], add __counted_by for struct gcov_iterator.
>
> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
>
> Cc: Peter Oberparleiter <oberpar@linux.ibm.com>
> Signed-off-by: Kees Cook <keescook@chromium.org>
Looks good to me!
Reviewed-by: Peter Oberparleiter <oberpar@linux.ibm.com>
Andrew, could you add this patch via your tree?
--
Peter Oberparleiter
Linux on IBM Z Development - IBM Germany R&D
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-05 16:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-22 17:52 [PATCH] gcov: Annotate struct gcov_iterator with __counted_by Kees Cook
2023-09-23 16:35 ` Gustavo A. R. Silva
2023-10-05 15:41 ` Peter Oberparleiter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox