Re: [RFC PATCH v2 0/6] KVM: gmem: Implement test cases for error_remove_page

Sean Christopherson
2023-09-21T21:43:38Z

On Thu, Sep 21, 2023, isaku.yamahata@intel.com wrote:
> From: Isaku Yamahata <isaku.yamahata@intel.com>
>
> This patch series is to implement test cases for the KVM gmem error_remove_page
> method.
> - Update punch hole method to truncate pages
> - Add a new ioctl KVM_GUEST_MEMORY_FAILURE to inject memory failure on
> offset of gmem

Doh. Please try to communicate what you're working on. I was just about to hit
SEND on a series to fix the truncation bug, and to add a similar test. I would
have happily punted that in your direction, but I had no idea that you were aware
of the bug[*], let alone working on a fix. I could have explicitly stated that
I was going to fix the bug, but I thought that it was implied that I needed to
clean up my own mess.

Anyways, I'm going to hit SEND anyways, my changes are slightly different to your
patch 1 (truncate needs to happen between begin() and end()) and patch 3 (I added
a slightly more comprehensive test).

[*] https://lore.kernel.org/all/20230918163647.m6bjgwusc7ww5tyu@amd.com