From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 308DBCD4F57 for ; Fri, 22 Sep 2023 10:40:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233397AbjIVKkF (ORCPT ); Fri, 22 Sep 2023 06:40:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233413AbjIVKkA (ORCPT ); Fri, 22 Sep 2023 06:40:00 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB8B5E8 for ; Fri, 22 Sep 2023 03:39:53 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D083BC433C8; Fri, 22 Sep 2023 10:39:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1695379193; bh=ClMmkQmtEvP1Zh8b7X6oZZjA1vgE2eFdOh0zMYLqaQg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aPitWE9T8fBhng7NWIhVaZpNJJxUWOSX8rV+HIZHHQZotbCSj1Wj28WLN41R2ITgZ vk/dgicrL+ZYtjW0kztYiwCJa7RKE5/oSNS4nzOLt7z3aPrb+zNjCJT4uwPzFp0zrq xsJ15YaCQ/+Wq3VQxf6k77i4Vze7sJtGnggZbvwc= Date: Fri, 22 Sep 2023 12:39:50 +0200 From: Greg Kroah-Hartman To: Prashanth K Cc: linux-kernel@vger.kernel.org, Hongyu Xie , Mathias Nyman , stable@kernel.org, Hongyu Xie , Mathias Nyman Subject: Re: [PATCH] xhci: Keep interrupt disabled in initialization until host is running. Message-ID: <2023092236-cogwheel-skied-0841@gregkh> References: <1695374501-22649-1-git-send-email-quic_prashk@quicinc.com> <2023092256-smudge-disallow-48d3@gregkh> <56e210a4-8106-db7a-f44d-e40421e5abf7@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56e210a4-8106-db7a-f44d-e40421e5abf7@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 22, 2023 at 04:03:26PM +0530, Prashanth K wrote: > > > On 22-09-23 04:00 pm, Greg Kroah-Hartman wrote: > > On Fri, Sep 22, 2023 at 02:51:41PM +0530, Prashanth K wrote: > > > From: Hongyu Xie > > > > > > [ Upstream commit 808925075fb750804a60ff0710614466c396db4 ] > > > > > > irq is disabled in xhci_quiesce(called by xhci_halt, with bit:2 cleared > > > in USBCMD register), but xhci_run(called by usb_add_hcd) re-enable it. > > > It's possible that you will receive thousands of interrupt requests > > > after initialization for 2.0 roothub. And you will get a lot of > > > warning like, "xHCI dying, ignoring interrupt. Shouldn't IRQs be > > > disabled?". This amount of interrupt requests will cause the entire > > > system to freeze. > > > This problem was first found on a device with ASM2142 host controller > > > on it. > > > > > > [tidy up old code while moving it, reword header -Mathias] > > > > > > Cc: stable@kernel.org > > > Signed-off-by: Hongyu Xie > > > Signed-off-by: Mathias Nyman > > > Link: https://lore.kernel.org/r/20220623111945.1557702-2-mathias.nyman@linux.intel.com > > > Signed-off-by: Greg Kroah-Hartman > > > --- > > > drivers/usb/host/xhci.c | 34 +++++++++++++++++++++------------- > > > 1 file changed, 21 insertions(+), 13 deletions(-) > > > > What stable kernel(s) are you asking this to be applied to? > > > > greg k-h > Need this patch on v5.15, I had cc'ed "stable@kernel.org # 5.15", but looks > like it didn't work. Should I resend this with SOB and CC tags? Yes please. thanks, greg k-h