From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3FF9CE7A8A for ; Sun, 24 Sep 2023 13:30:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231661AbjIXNax (ORCPT ); Sun, 24 Sep 2023 09:30:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230202AbjIXNaK (ORCPT ); Sun, 24 Sep 2023 09:30:10 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96D8549E1; Sun, 24 Sep 2023 06:20:07 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40071C433C8; Sun, 24 Sep 2023 13:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695561607; bh=VgzScr0MNiMapNF1req0QGLGZBlYTIuU+SYyIVQsJNE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nyme4kMt/+s5z0xXMZt1izEKKvSvhl0T9YpS7ZaUY5JjDdqhZmn7GxwmsnHyAjc73 7bWJi95t/gvzu+YVkpVX3GoY+hoRDWimJDyDP4aaRf/Cj7uagJnoMzjuRo8YbsnLQB s7ofgF9Bm+rU/a2d7/TMerZ44jnNg3z1+4j9UpnNOKgTN+6TwQ1XBXYqkTMs2kkABn USsPOrqgWDHKpdOqmDqTgnNazKJqXE7HbtEEJhNDtSPI6E+vrP6aoobPhzQOj4eHKv haLxczVtCEcDRWwbvPl6t6I0xdXIe0aTxgqEwEj0Xno6jJP00x7Ll2GdivSRzD/3NQ Va2ua/MKp7k8Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: "Steven Rostedt (Google)" , Masami Hiramatsu , Mark Rutland , Tze-nan Wu , Sasha Levin , matthias.bgg@gmail.com, linux-trace-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH AUTOSEL 5.10 09/13] ring-buffer: Do not attempt to read past "commit" Date: Sun, 24 Sep 2023 09:19:39 -0400 Message-Id: <20230924131945.1276562-9-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230924131945.1276562-1-sashal@kernel.org> References: <20230924131945.1276562-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.197 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Steven Rostedt (Google)" [ Upstream commit 95a404bd60af6c4d9d8db01ad14fe8957ece31ca ] When iterating over the ring buffer while the ring buffer is active, the writer can corrupt the reader. There's barriers to help detect this and handle it, but that code missed the case where the last event was at the very end of the page and has only 4 bytes left. The checks to detect the corruption by the writer to reads needs to see the length of the event. If the length in the first 4 bytes is zero then the length is stored in the second 4 bytes. But if the writer is in the process of updating that code, there's a small window where the length in the first 4 bytes could be zero even though the length is only 4 bytes. That will cause rb_event_length() to read the next 4 bytes which could happen to be off the allocated page. To protect against this, fail immediately if the next event pointer is less than 8 bytes from the end of the commit (last byte of data), as all events must be a minimum of 8 bytes anyway. Link: https://lore.kernel.org/all/20230905141245.26470-1-Tze-nan.Wu@mediatek.com/ Link: https://lore.kernel.org/linux-trace-kernel/20230907122820.0899019c@gandalf.local.home Cc: Masami Hiramatsu Cc: Mark Rutland Reported-by: Tze-nan Wu Signed-off-by: Steven Rostedt (Google) Signed-off-by: Sasha Levin --- kernel/trace/ring_buffer.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c index 752e9549a59e8..812ec380da820 100644 --- a/kernel/trace/ring_buffer.c +++ b/kernel/trace/ring_buffer.c @@ -2260,6 +2260,11 @@ rb_iter_head_event(struct ring_buffer_iter *iter) */ commit = rb_page_commit(iter_head_page); smp_rmb(); + + /* An event needs to be at least 8 bytes in size */ + if (iter->head > commit - 8) + goto reset; + event = __rb_page_index(iter_head_page, iter->head); length = rb_event_length(event); -- 2.40.1