From: Jernej Skrabec <jernej.skrabec@gmail.com>
To: mripard@kernel.org, wens@csie.org
Cc: airlied@gmail.com, daniel@ffwll.ch, samuel@sholland.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@gmail.com>
Subject: [PATCH 0/7] drm/sun4i: dw-hdmi: Fix initialization & refactor
Date: Sun, 24 Sep 2023 21:25:57 +0200 [thread overview]
Message-ID: <20230924192604.3262187-1-jernej.skrabec@gmail.com> (raw)
Main goal of this series is to fix race condition between probing display
connector driver and sun8i dw-hdmi platform driver. Sometimes, boards have
ddc-en gpio specified in DT file. This is handled by display connector
driver since commit 920169041baa ("drm/sun4i: dw-hdmi: Fix ddc-en GPIO
consumer conflict"). However, because there is no link between it and
sun8i dw-hdmi driver, probe order isn't determined. If display connector
driver if probed afterwards, then sun8i dw-hdmi driver won't be able to
read EDID and thus fall back to 1024x768. This can be easily solved by
using bridges and linking them together. Coincidentally, switching to
bridge model is also long term goal.
I found out some other issues when working on them (missing phy deinit and
memory corruption during executing fail path). Since there is now a bigger
chance of deferring probe, it's also good to skip reporting deferred probe
as error. This often confuses users when examining dmesg output, especially
if there is no error code reported.
I also throw 2 refactoring patches for a good measure.
Please take a look.
Best regards,
Jernej
Jernej Skrabec (7):
drm/sun4i: dw-hdmi: Deinit PHY in fail path
drm/sun4i: dw-hdmi: Remove double encoder cleanup
drm/sun4i: dw-hdmi: Switch to bridge functions
drm/sun4i: Don't show error for deferred probes.
drm/sun4i: dw-hdmi: Split driver registration
drm/sun4i: dw-hdmi: Make sun8i_hdmi_phy_get() more intuitive
drm/sun4i: dw-hdmi: check for phy device first
drivers/gpu/drm/sun4i/sun4i_drv.c | 3 +-
drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 191 ++++++++++++++++++-------
drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h | 9 +-
drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c | 13 +-
4 files changed, 151 insertions(+), 65 deletions(-)
--
2.42.0
next reply other threads:[~2023-09-24 19:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-24 19:25 Jernej Skrabec [this message]
2023-09-24 19:25 ` [PATCH 1/7] drm/sun4i: dw-hdmi: Deinit PHY in fail path Jernej Skrabec
2023-09-25 7:43 ` Maxime Ripard
2023-09-24 19:25 ` [PATCH 2/7] drm/sun4i: dw-hdmi: Remove double encoder cleanup Jernej Skrabec
2023-09-25 7:44 ` Maxime Ripard
2023-09-24 19:26 ` [PATCH 3/7] drm/sun4i: dw-hdmi: Switch to bridge functions Jernej Skrabec
2023-09-25 7:57 ` Maxime Ripard
2023-09-25 15:29 ` Jernej Škrabec
2023-10-05 8:42 ` Maxime Ripard
2023-09-24 19:26 ` [PATCH 4/7] drm/sun4i: Don't show error for deferred probes Jernej Skrabec
2023-09-25 7:45 ` Maxime Ripard
2023-09-24 19:26 ` [PATCH 5/7] drm/sun4i: dw-hdmi: Split driver registration Jernej Skrabec
2023-09-25 2:35 ` kernel test robot
2023-09-25 7:47 ` Maxime Ripard
2023-09-25 15:07 ` Jernej Škrabec
2023-10-05 8:43 ` Maxime Ripard
2023-10-13 19:50 ` Jernej Škrabec
2023-09-25 16:40 ` kernel test robot
2023-09-24 19:26 ` [PATCH 6/7] drm/sun4i: dw-hdmi: Make sun8i_hdmi_phy_get() more intuitive Jernej Skrabec
2023-09-24 19:26 ` [PATCH 7/7] drm/sun4i: dw-hdmi: check for phy device first Jernej Skrabec
2023-09-25 7:50 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230924192604.3262187-1-jernej.skrabec@gmail.com \
--to=jernej.skrabec@gmail.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox