From: Christian Brauner <brauner@kernel.org>
To: Max Kellermann <max.kellermann@ionos.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/splice: don't block splice_direct_to_actor() after data was read
Date: Mon, 25 Sep 2023 15:10:27 +0200 [thread overview]
Message-ID: <20230925-erstklassig-flausen-48e1bc11be30@brauner> (raw)
In-Reply-To: <CAKPOu+_fwVZFXhTuzcWneNcjHJ99n00j_oq+sF8P-zvsPCOdVQ@mail.gmail.com>
On Wed, Sep 20, 2023 at 08:16:04PM +0200, Max Kellermann wrote:
> On Wed, Sep 20, 2023 at 7:28 PM Jens Axboe <axboe@kernel.dk> wrote:
> > I think adding the flag for this case makes sense, and also exposing it
> > on the UAPI side.
>
> OK. I suggest we get this patch merged first, and then I prepare a
> patch for wiring this into uapi, changing SPLICE_F_NOWAIT to 0x10 (the
> lowest free bit), add it to SPLICE_F_ALL and document it.
>
> (If you prefer to have it all in this initial patch, I can amend and
> resubmit it with the uapi feature.)
Please resend it all in one patch. That's easier for all to review.
next prev parent reply other threads:[~2023-09-25 13:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 8:12 [PATCH] fs/splice: don't block splice_direct_to_actor() after data was read Max Kellermann
2023-09-19 14:18 ` Christian Brauner
2023-09-20 17:28 ` Jens Axboe
2023-09-20 18:16 ` Max Kellermann
2023-09-25 13:10 ` Christian Brauner [this message]
2023-09-26 6:36 ` [PATCH v2] " Max Kellermann
2023-09-26 10:21 ` Christian Brauner
2023-09-26 10:41 ` Max Kellermann
2023-09-26 12:26 ` Christian Brauner
2023-09-26 6:39 ` [PATCH] " Max Kellermann
-- strict thread matches above, loose matches on Subject: below --
2022-11-05 9:04 Max Kellermann
2022-11-08 7:37 ` Christoph Hellwig
2022-11-20 13:19 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230925-erstklassig-flausen-48e1bc11be30@brauner \
--to=brauner@kernel.org \
--cc=axboe@kernel.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max.kellermann@ionos.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox