From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C8DDCE7AAB for ; Mon, 25 Sep 2023 17:13:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233008AbjIYRNd (ORCPT ); Mon, 25 Sep 2023 13:13:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232800AbjIYRNa (ORCPT ); Mon, 25 Sep 2023 13:13:30 -0400 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10F79124 for ; Mon, 25 Sep 2023 10:13:22 -0700 (PDT) Received: by mail-pg1-x533.google.com with SMTP id 41be03b00d2f7-53fbf2c42bfso5215651a12.3 for ; Mon, 25 Sep 2023 10:13:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1695662001; x=1696266801; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=C8AVXr6vllU577ND8JQi6s5Wb2XnBxy1FQk2gXYImts=; b=nwdwXGckYPlPX21pEof3xnvcqZtcLo+KJ3+jVK0axkL3B9r8vRWYdHvuPmYQG+0SMW 0kplhw0TQhtU0Iwi8LNa4wT1D+uBm3rl8SZyA+8Yw+2aNjTVr3NIha6HuMFqSvToYIPN 2KvBec9sl1KfxAXU/PbYcm2nl3P/IgqmPDnkQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695662001; x=1696266801; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C8AVXr6vllU577ND8JQi6s5Wb2XnBxy1FQk2gXYImts=; b=lNh/aZnQYuCuZWlUboVSodxI9YOGg872smlSkDh0h4knRhQtapHC4noacBNDnvHj0z ONrjHgDMuIEWoAOncKRSyK4xdJOdxJzhrNv0SLze2gbsajNCM4wm+CYG2nzdirrdqOWq XbJqllOTg2DhF0sECkGK3pwz6pn8UHkarIyqQHqNpoQ2wdZZPTsOgt9h6Lq/odCCoN3a qJZwjkE8eP8WMqrYNO5ao/arMcby7H34WeaHjbvNJ4qXRlwuH4P1TNyKtDvi8IOhAlto WnFf4NQjksGuPoMvc/7nvrvW4nlmG2651ZqhVOxzlTFSfbU0WWCGla8gfoOh0580vTGg gAgw== X-Gm-Message-State: AOJu0YwHkTj5w43iCtW9nyOnBcbofpspV+/lcZok7N2slKAJ7NVLg23/ FF9AOzYJ8SQi+7xy8V2lHnJgkA== X-Google-Smtp-Source: AGHT+IHWl3AN866Dif5RDGSG6cKkeY0zzlRZ9iz5O7jZ3LOhJATZBUXvLNzYu+Ccp3gZwtb6gOE9uw== X-Received: by 2002:a17:90a:4e4e:b0:268:f987:305f with SMTP id t14-20020a17090a4e4e00b00268f987305fmr6859749pjl.46.1695662001491; Mon, 25 Sep 2023 10:13:21 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id 20-20020a17090a199400b00268b439a0cbsm9146846pji.23.2023.09.25.10.13.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 10:13:21 -0700 (PDT) Date: Mon, 25 Sep 2023 10:13:20 -0700 From: Kees Cook To: Shuai Xue Cc: tony.luck@intel.com, gpiccoli@igalia.com, rafael@kernel.org, lenb@kernel.org, james.morse@arm.com, bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, ardb@kernel.org, robert.moore@intel.com, linux-hardening@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-efi@vger.kernel.org, acpica-devel@lists.linuxfoundation.org, baolin.wang@linux.alibaba.com Subject: Re: [RFC PATCH v2 1/9] pstore: move pstore creator id, section type and record struct to common header Message-ID: <202309251012.AD87704BB@keescook> References: <20230925074426.97856-1-xueshuai@linux.alibaba.com> <20230925074426.97856-2-xueshuai@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230925074426.97856-2-xueshuai@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 25, 2023 at 03:44:18PM +0800, Shuai Xue wrote: > Move pstore creator id, section type and record struct to the common > header, so that it can be use by MCE and GHES driver. I would prefer this was not in the pstore header -- this is a backend detail that should stay in backend headers. -Kees -- Kees Cook