From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2CE4CE7A81 for ; Mon, 25 Sep 2023 10:10:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229712AbjIYKKF (ORCPT ); Mon, 25 Sep 2023 06:10:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230415AbjIYKKB (ORCPT ); Mon, 25 Sep 2023 06:10:01 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83E8D1A8; Mon, 25 Sep 2023 03:09:54 -0700 (PDT) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4RvJTM6HQcz6D8gD; Mon, 25 Sep 2023 18:07:35 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 25 Sep 2023 11:09:52 +0100 Date: Mon, 25 Sep 2023 11:09:51 +0100 From: Jonathan Cameron To: Jeongtae Park CC: Dan Williams , Alison Schofield , Vishal Verma , "Ben Widawsky" , Dave Jiang , Davidlohr Bueso , Fan Ni , , , Greg Kroah-Hartman , Kyungsan Kim , "Wonjae Lee" , Hojin Nam , Junhyeok Im , Jehoon Park , "Jeongtae Park" Subject: Re: [PATCH v2 4/7] cxl: Fix a checkpatch error Message-ID: <20230925110951.000017ff@Huawei.com> In-Reply-To: <20230922113604.3300468-1-jtp.park@samsung.com> References: <20230922113604.3300468-1-jtp.park@samsung.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500003.china.huawei.com (7.191.162.67) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 22 Sep 2023 20:36:04 +0900 Jeongtae Park wrote: > ERROR: Macros with complex values should be enclosed in parentheses > > Signed-off-by: Jeongtae Park > Reviewed-by: Dave Jiang Reviewed-by: Jonathan Cameron I checked the places this is used and it won't result in any functional change so good to tidy it up. > --- > drivers/cxl/cxl.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h > index 76d92561af29..545381355efb 100644 > --- a/drivers/cxl/cxl.h > +++ b/drivers/cxl/cxl.h > @@ -142,7 +142,7 @@ static inline int ways_to_eiw(unsigned int ways, u8 *eiw) > #define CXL_RAS_HEADER_LOG_OFFSET 0x18 > #define CXL_RAS_CAPABILITY_LENGTH 0x58 > #define CXL_HEADERLOG_SIZE SZ_512 > -#define CXL_HEADERLOG_SIZE_U32 SZ_512 / sizeof(u32) > +#define CXL_HEADERLOG_SIZE_U32 (SZ_512 / sizeof(u32)) > > /* CXL 2.0 8.2.8.1 Device Capabilities Array Register */ > #define CXLDEV_CAP_ARRAY_OFFSET 0x0