* Re: [PATCH v2 6/7] cxl/memdev: Fix a whitespace error
2023-09-22 11:36 ` [PATCH v2 6/7] cxl/memdev: Fix a whitespace error Jeongtae Park
@ 2023-09-22 15:07 ` Dave Jiang
2023-09-25 10:12 ` Jonathan Cameron
1 sibling, 0 replies; 3+ messages in thread
From: Dave Jiang @ 2023-09-22 15:07 UTC (permalink / raw)
To: Jeongtae Park, Dan Williams, Alison Schofield, Vishal Verma,
Ben Widawsky, Jonathan Cameron, Davidlohr Bueso, Fan Ni,
linux-cxl
Cc: linux-kernel, Greg Kroah-Hartman, Kyungsan Kim, Wonjae Lee,
Hojin Nam, Junhyeok Im, Jehoon Park, Jeongtae Park
On 9/22/23 04:36, Jeongtae Park wrote:
> ERROR: code indent should use tabs where possible
>
> Signed-off-by: Jeongtae Park <jtp.park@samsung.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/cxl/core/memdev.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c
> index f99e7ec3cc40..7e8fca4707c0 100644
> --- a/drivers/cxl/core/memdev.c
> +++ b/drivers/cxl/core/memdev.c
> @@ -935,11 +935,11 @@ static void cxl_fw_cancel(struct fw_upload *fwl)
> }
>
> static const struct fw_upload_ops cxl_memdev_fw_ops = {
> - .prepare = cxl_fw_prepare,
> - .write = cxl_fw_write,
> - .poll_complete = cxl_fw_poll_complete,
> - .cancel = cxl_fw_cancel,
> - .cleanup = cxl_fw_cleanup,
> + .prepare = cxl_fw_prepare,
> + .write = cxl_fw_write,
> + .poll_complete = cxl_fw_poll_complete,
> + .cancel = cxl_fw_cancel,
> + .cleanup = cxl_fw_cleanup,
> };
>
> static void devm_cxl_remove_fw_upload(void *fwl)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2 6/7] cxl/memdev: Fix a whitespace error
2023-09-22 11:36 ` [PATCH v2 6/7] cxl/memdev: Fix a whitespace error Jeongtae Park
2023-09-22 15:07 ` Dave Jiang
@ 2023-09-25 10:12 ` Jonathan Cameron
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2023-09-25 10:12 UTC (permalink / raw)
To: Jeongtae Park
Cc: Dan Williams, Alison Schofield, Vishal Verma, Ben Widawsky,
Dave Jiang, Davidlohr Bueso, Fan Ni, linux-cxl, linux-kernel,
Greg Kroah-Hartman, Kyungsan Kim, Wonjae Lee, Hojin Nam,
Junhyeok Im, Jehoon Park, Jeongtae Park
On Fri, 22 Sep 2023 20:36:36 +0900
Jeongtae Park <jtp.park@samsung.com> wrote:
> ERROR: code indent should use tabs where possible
>
> Signed-off-by: Jeongtae Park <jtp.park@samsung.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
These whitespace ones are simple enough RB feels over the top :)
Jonathan
> ---
> drivers/cxl/core/memdev.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c
> index f99e7ec3cc40..7e8fca4707c0 100644
> --- a/drivers/cxl/core/memdev.c
> +++ b/drivers/cxl/core/memdev.c
> @@ -935,11 +935,11 @@ static void cxl_fw_cancel(struct fw_upload *fwl)
> }
>
> static const struct fw_upload_ops cxl_memdev_fw_ops = {
> - .prepare = cxl_fw_prepare,
> - .write = cxl_fw_write,
> - .poll_complete = cxl_fw_poll_complete,
> - .cancel = cxl_fw_cancel,
> - .cleanup = cxl_fw_cleanup,
> + .prepare = cxl_fw_prepare,
> + .write = cxl_fw_write,
> + .poll_complete = cxl_fw_poll_complete,
> + .cancel = cxl_fw_cancel,
> + .cleanup = cxl_fw_cleanup,
> };
>
> static void devm_cxl_remove_fw_upload(void *fwl)
^ permalink raw reply [flat|nested] 3+ messages in thread