* Re: [PATCH v2 7/7] cxl/memdev: Fix a whitespace warning
2023-09-22 11:36 ` [PATCH v2 7/7] cxl/memdev: Fix a whitespace warning Jeongtae Park
@ 2023-09-22 15:07 ` Dave Jiang
2023-09-25 10:12 ` Jonathan Cameron
2023-09-28 1:31 ` Davidlohr Bueso
2 siblings, 0 replies; 5+ messages in thread
From: Dave Jiang @ 2023-09-22 15:07 UTC (permalink / raw)
To: Jeongtae Park, Dan Williams, Alison Schofield, Vishal Verma,
Ben Widawsky, Jonathan Cameron, Davidlohr Bueso, Fan Ni,
linux-cxl
Cc: linux-kernel, Greg Kroah-Hartman, Kyungsan Kim, Wonjae Lee,
Hojin Nam, Junhyeok Im, Jehoon Park, Jeongtae Park
On 9/22/23 04:36, Jeongtae Park wrote:
> WARNING: please, no spaces at the start of a line
>
> Signed-off-by: Jeongtae Park <jtp.park@samsung.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/cxl/core/memdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c
> index 7e8fca4707c0..ce67df163452 100644
> --- a/drivers/cxl/core/memdev.c
> +++ b/drivers/cxl/core/memdev.c
> @@ -1010,7 +1010,7 @@ static int cxl_memdev_security_init(struct cxl_memdev *cxlmd)
> }
>
> return devm_add_action_or_reset(cxlds->dev, put_sanitize, mds);
> - }
> +}
>
> struct cxl_memdev *devm_cxl_add_memdev(struct cxl_dev_state *cxlds)
> {
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2 7/7] cxl/memdev: Fix a whitespace warning
2023-09-22 11:36 ` [PATCH v2 7/7] cxl/memdev: Fix a whitespace warning Jeongtae Park
2023-09-22 15:07 ` Dave Jiang
@ 2023-09-25 10:12 ` Jonathan Cameron
2023-09-28 1:31 ` Davidlohr Bueso
2 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2023-09-25 10:12 UTC (permalink / raw)
To: Jeongtae Park
Cc: Dan Williams, Alison Schofield, Vishal Verma, Ben Widawsky,
Dave Jiang, Davidlohr Bueso, Fan Ni, linux-cxl, linux-kernel,
Greg Kroah-Hartman, Kyungsan Kim, Wonjae Lee, Hojin Nam,
Junhyeok Im, Jehoon Park, Jeongtae Park
On Fri, 22 Sep 2023 20:36:50 +0900
Jeongtae Park <jtp.park@samsung.com> wrote:
> WARNING: please, no spaces at the start of a line
>
> Signed-off-by: Jeongtae Park <jtp.park@samsung.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/cxl/core/memdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c
> index 7e8fca4707c0..ce67df163452 100644
> --- a/drivers/cxl/core/memdev.c
> +++ b/drivers/cxl/core/memdev.c
> @@ -1010,7 +1010,7 @@ static int cxl_memdev_security_init(struct cxl_memdev *cxlmd)
> }
>
> return devm_add_action_or_reset(cxlds->dev, put_sanitize, mds);
> - }
> +}
>
> struct cxl_memdev *devm_cxl_add_memdev(struct cxl_dev_state *cxlds)
> {
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2 7/7] cxl/memdev: Fix a whitespace warning
2023-09-22 11:36 ` [PATCH v2 7/7] cxl/memdev: Fix a whitespace warning Jeongtae Park
2023-09-22 15:07 ` Dave Jiang
2023-09-25 10:12 ` Jonathan Cameron
@ 2023-09-28 1:31 ` Davidlohr Bueso
2023-10-04 9:00 ` Jeongtae Park
2 siblings, 1 reply; 5+ messages in thread
From: Davidlohr Bueso @ 2023-09-28 1:31 UTC (permalink / raw)
To: Jeongtae Park
Cc: Dan Williams, Alison Schofield, Vishal Verma, Ben Widawsky,
Jonathan Cameron, Dave Jiang, Fan Ni, linux-cxl, linux-kernel,
Greg Kroah-Hartman, Kyungsan Kim, Wonjae Lee, Hojin Nam,
Junhyeok Im, Jehoon Park, Jeongtae Park
On Fri, 22 Sep 2023, Jeongtae Park wrote:
>WARNING: please, no spaces at the start of a line
>
>Signed-off-by: Jeongtae Park <jtp.park@samsung.com>
>---
> drivers/cxl/core/memdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c
>index 7e8fca4707c0..ce67df163452 100644
>--- a/drivers/cxl/core/memdev.c
>+++ b/drivers/cxl/core/memdev.c
>@@ -1010,7 +1010,7 @@ static int cxl_memdev_security_init(struct cxl_memdev *cxlmd)
> }
>
> return devm_add_action_or_reset(cxlds->dev, put_sanitize, mds);
>- }
>+}
While nothing wrong, I do prefer this being corrected via
https://lore.kernel.org/linux-cxl/20230811025755.15103-1-dave@stgolabs.net/
Thanks,
Davidlohr
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 7/7] cxl/memdev: Fix a whitespace warning
2023-09-28 1:31 ` Davidlohr Bueso
@ 2023-10-04 9:00 ` Jeongtae Park
0 siblings, 0 replies; 5+ messages in thread
From: Jeongtae Park @ 2023-10-04 9:00 UTC (permalink / raw)
To: Davidlohr Bueso
Cc: Dan Williams, Alison Schofield, Vishal Verma, Ben Widawsky,
Jonathan Cameron, Dave Jiang, Fan Ni, linux-cxl, linux-kernel,
Greg Kroah-Hartman, Kyungsan Kim, Wonjae Lee, Hojin Nam,
Junhyeok Im, Jehoon Park, Jeongtae Park
[-- Attachment #1: Type: text/plain, Size: 951 bytes --]
On Wed, Sep 27, 2023 at 06:31:37PM -0700, Davidlohr Bueso wrote:
> On Fri, 22 Sep 2023, Jeongtae Park wrote:
>
> > WARNING: please, no spaces at the start of a line
> >
> > Signed-off-by: Jeongtae Park <jtp.park@samsung.com>
> > ---
> > drivers/cxl/core/memdev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c
> > index 7e8fca4707c0..ce67df163452 100644
> > --- a/drivers/cxl/core/memdev.c
> > +++ b/drivers/cxl/core/memdev.c
> > @@ -1010,7 +1010,7 @@ static int cxl_memdev_security_init(struct cxl_memdev *cxlmd)
> > }
> >
> > return devm_add_action_or_reset(cxlds->dev, put_sanitize, mds);
> > - }
> > +}
>
> While nothing wrong, I do prefer this being corrected via
>
> https://lore.kernel.org/linux-cxl/20230811025755.15103-1-dave@stgolabs.net/
That's better, I didn't know there was a related fix. Thanks for letting me know.
>
> Thanks,
> Davidlohr
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread