From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61F1ACE7A81 for ; Mon, 25 Sep 2023 11:58:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230445AbjIYL6V (ORCPT ); Mon, 25 Sep 2023 07:58:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbjIYL6U (ORCPT ); Mon, 25 Sep 2023 07:58:20 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C1FAA9 for ; Mon, 25 Sep 2023 04:58:14 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D001AC433C9; Mon, 25 Sep 2023 11:58:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695643093; bh=fnrScfrKmcUIyzu4ZV2T/hRDgwvbstyPfcJB+K3Mt+E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T2+C6At+KWCOneZdF9ndelbxD6lIlwEqLD5B4GkLJVvPLAugbJF8PLgU/BjUeBdo5 cgcVcJLgJrZ1DRyBNc4dy5vsGnQ4z381cE68hRpDY1CFhHHGl81GpaRPzqjnmiQ4rU OiLAys6htFg9zDX3e/XxSGLwRwakQQbhf14KxSVafObTTeKY6yjLw15m8UvpsJNZGA slYjF1U0+VbCdXV8JqrjgI/daRFJFKbQ1s3+uHG5Zv8saXDZzbbnIzNeNmpD8e6dkV TeTyhnrONUryeHgjgFn3fJ7Rh8SCcCyV9TjK4KlpCPcbiQAp2KB5y8FeeNECF2jvkS xyJspr24HZCXw== Date: Mon, 25 Sep 2023 19:58:03 +0800 From: Peter Chen To: Xiaolei Wang Cc: pawell@cadence.com, pavel@denx.de, rogerq@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] usb: cdns3: Modify the return value of cdns_set_active () to void when CONFIG_PM_SLEEP is disabled Message-ID: <20230925115803.GD2070044@nchen-desktop> References: <20230920144045.2165758-1-xiaolei.wang@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230920144045.2165758-1-xiaolei.wang@windriver.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23-09-20 22:40:45, Xiaolei Wang wrote: > The return type of cdns_set_active () is inconsistent > depending on whether CONFIG_PM_SLEEP is enabled, so the > return value is modified to void type. > > Reported-by: Pavel Machek > Closes: https://lore.kernel.org/all/ZP7lIKUzD68XA91j@duo.ucw.cz/ > Fixes: 2319b9c87fe2 ("usb: cdns3: Put the cdns set active part outside the spin lock") > Cc: stable@vger.kernel.org > Signed-off-by: Xiaolei Wang > Reviewed-by: Pavel Machek > Reviewed-by: Roger Quadros > --- > > Changes in v3: > - Add Cc: stable@vger.kernel.org > > --- Above "---" doesn't need. Peter > drivers/usb/cdns3/core.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/usb/cdns3/core.h b/drivers/usb/cdns3/core.h > index 4a4dbc2c1561..81a9c9d6be08 100644 > --- a/drivers/usb/cdns3/core.h > +++ b/drivers/usb/cdns3/core.h > @@ -131,8 +131,7 @@ void cdns_set_active(struct cdns *cdns, u8 set_active); > #else /* CONFIG_PM_SLEEP */ > static inline int cdns_resume(struct cdns *cdns) > { return 0; } > -static inline int cdns_set_active(struct cdns *cdns, u8 set_active) > -{ return 0; } > +static inline void cdns_set_active(struct cdns *cdns, u8 set_active) { } > static inline int cdns_suspend(struct cdns *cdns) > { return 0; } > #endif /* CONFIG_PM_SLEEP */ > -- > 2.25.1 > -- Thanks, Peter Chen