From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2F9FCE7A8C for ; Mon, 25 Sep 2023 15:54:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232828AbjIYPyh (ORCPT ); Mon, 25 Sep 2023 11:54:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232596AbjIYPyf (ORCPT ); Mon, 25 Sep 2023 11:54:35 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 647E292 for ; Mon, 25 Sep 2023 08:54:29 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39800C433C8; Mon, 25 Sep 2023 15:54:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695657269; bh=VbwuYfSftjz4yAlzxKgg+THJnGjMCtfrUoHPB+hCAGI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T0MwjoFQyuNUeUaE2hTBr1gh5Sz2OLJTVdVvw/FqELkETvLI8+stNeQMILiRP9run JxmrQiDjBbqisGW9HmUZ9VZk3XCZ0aCMX85iw6YApZZAb/bALSjfpWyMs6m1bpkGL8 PvbC1Y6a972zMHFwHd64OZ7QUcGSj0MgNsPDC1FwJfM6EpAyvupj9elnTaecoOEIhA wCIjC7c9cDCiwKCjm6gx1zwtG1tcepvTy7mmHHz238J7yV1entUqyjQ/hjd4y0/g7t G6VNZiH2lKqVvdxEEt+HeOl6zm5UQnNE9xrVHpnGGD9n0jbKDf87KGEIABFNd3tzRY c832cDme1GApA== From: Arnd Bergmann To: Greg Kroah-Hartman Cc: Arnd Bergmann , Philipp Hortmann , Tree Davies , Yogesh Hegde , Sumitra Sharma , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] staging: rtl8192e: remove bogus __packed annotations Date: Mon, 25 Sep 2023 17:54:04 +0200 Message-Id: <20230925155413.471287-2-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230925155413.471287-1-arnd@kernel.org> References: <20230925155413.471287-1-arnd@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann The rtllib_rxb structure contains a pointer, so this is not a hardware structure but could benefit from loading the pointer in a single instruction rather than assembling it from four or eight individual bytes. Both structures are allocated as part of larger structure that already enforce at least a 4-byte alignment, so there is no reason to ever have to deal with misaligned definitions. Signed-off-by: Arnd Bergmann --- drivers/staging/rtl8192e/rtllib.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index 7d26910a0b162..fe7b58ae33995 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -172,7 +172,7 @@ struct sw_chnl_cmd { u32 Para1; u32 Para2; u32 msDelay; -} __packed; +}; /*--------------------------Define -------------------------------------------*/ #define MGN_1M 0x02 @@ -707,7 +707,7 @@ struct rtllib_rxb { struct sk_buff *subframes[MAX_SUBFRAME_COUNT]; u8 dst[ETH_ALEN]; u8 src[ETH_ALEN]; -} __packed; +}; union frameqos { u16 shortdata; -- 2.39.2