* [PATCH] media: dt-bindings: Add missing unevaluatedProperties on child node schemas
@ 2023-09-25 21:27 Rob Herring
2023-09-26 13:03 ` Conor Dooley
2023-10-06 18:52 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2023-09-25 21:27 UTC (permalink / raw)
To: Michael Riesch, Mauro Carvalho Chehab, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Sylwester Nawrocki
Cc: Krzysztof Kozlowski, linux-media, devicetree, linux-arm-kernel,
linux-kernel
Just as unevaluatedProperties or additionalProperties are required at
the top level of schemas, they should (and will) also be required for
child node schemas. That ensures only documented properties are
present for any node.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml | 1 +
.../devicetree/bindings/media/i2c/toshiba,tc358746.yaml | 2 ++
Documentation/devicetree/bindings/media/samsung,fimc.yaml | 1 +
3 files changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
index ffccf5f3c9e3..642f9b15d359 100644
--- a/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
@@ -54,6 +54,7 @@ properties:
port:
$ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
properties:
endpoint:
diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.yaml b/Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.yaml
index c5cab549ee8e..1c476b635b69 100644
--- a/Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.yaml
@@ -69,6 +69,7 @@ properties:
properties:
port@0:
$ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
description: Input port
properties:
@@ -89,6 +90,7 @@ properties:
port@1:
$ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
description: Output port
properties:
diff --git a/Documentation/devicetree/bindings/media/samsung,fimc.yaml b/Documentation/devicetree/bindings/media/samsung,fimc.yaml
index 79ff6d83a9fd..b3486c38a05b 100644
--- a/Documentation/devicetree/bindings/media/samsung,fimc.yaml
+++ b/Documentation/devicetree/bindings/media/samsung,fimc.yaml
@@ -57,6 +57,7 @@ properties:
patternProperties:
"^port@[01]$":
$ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
description:
Camera A and camera B inputs.
--
2.40.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] media: dt-bindings: Add missing unevaluatedProperties on child node schemas
2023-09-25 21:27 [PATCH] media: dt-bindings: Add missing unevaluatedProperties on child node schemas Rob Herring
@ 2023-09-26 13:03 ` Conor Dooley
2023-10-06 18:52 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2023-09-26 13:03 UTC (permalink / raw)
To: Rob Herring
Cc: Michael Riesch, Mauro Carvalho Chehab, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Sylwester Nawrocki,
Krzysztof Kozlowski, linux-media, devicetree, linux-arm-kernel,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2585 bytes --]
On Mon, Sep 25, 2023 at 04:27:58PM -0500, Rob Herring wrote:
> Just as unevaluatedProperties or additionalProperties are required at
> the top level of schemas, they should (and will) also be required for
> child node schemas. That ensures only documented properties are
> present for any node.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
> ---
> Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml | 1 +
> .../devicetree/bindings/media/i2c/toshiba,tc358746.yaml | 2 ++
> Documentation/devicetree/bindings/media/samsung,fimc.yaml | 1 +
> 3 files changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
> index ffccf5f3c9e3..642f9b15d359 100644
> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
> @@ -54,6 +54,7 @@ properties:
>
> port:
> $ref: /schemas/graph.yaml#/$defs/port-base
> + unevaluatedProperties: false
>
> properties:
> endpoint:
> diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.yaml b/Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.yaml
> index c5cab549ee8e..1c476b635b69 100644
> --- a/Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.yaml
> @@ -69,6 +69,7 @@ properties:
> properties:
> port@0:
> $ref: /schemas/graph.yaml#/$defs/port-base
> + unevaluatedProperties: false
> description: Input port
>
> properties:
> @@ -89,6 +90,7 @@ properties:
>
> port@1:
> $ref: /schemas/graph.yaml#/$defs/port-base
> + unevaluatedProperties: false
> description: Output port
>
> properties:
> diff --git a/Documentation/devicetree/bindings/media/samsung,fimc.yaml b/Documentation/devicetree/bindings/media/samsung,fimc.yaml
> index 79ff6d83a9fd..b3486c38a05b 100644
> --- a/Documentation/devicetree/bindings/media/samsung,fimc.yaml
> +++ b/Documentation/devicetree/bindings/media/samsung,fimc.yaml
> @@ -57,6 +57,7 @@ properties:
> patternProperties:
> "^port@[01]$":
> $ref: /schemas/graph.yaml#/$defs/port-base
> + unevaluatedProperties: false
> description:
> Camera A and camera B inputs.
>
> --
> 2.40.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: dt-bindings: Add missing unevaluatedProperties on child node schemas
2023-09-25 21:27 [PATCH] media: dt-bindings: Add missing unevaluatedProperties on child node schemas Rob Herring
2023-09-26 13:03 ` Conor Dooley
@ 2023-10-06 18:52 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2023-10-06 18:52 UTC (permalink / raw)
To: Rob Herring
Cc: linux-arm-kernel, linux-kernel, Mauro Carvalho Chehab,
Conor Dooley, Michael Riesch, devicetree, Fabio Estevam,
Shawn Guo, Krzysztof Kozlowski, Pengutronix Kernel Team,
linux-media, NXP Linux Team, Krzysztof Kozlowski, Sascha Hauer,
Sylwester Nawrocki
On Mon, 25 Sep 2023 16:27:58 -0500, Rob Herring wrote:
> Just as unevaluatedProperties or additionalProperties are required at
> the top level of schemas, they should (and will) also be required for
> child node schemas. That ensures only documented properties are
> present for any node.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml | 1 +
> .../devicetree/bindings/media/i2c/toshiba,tc358746.yaml | 2 ++
> Documentation/devicetree/bindings/media/samsung,fimc.yaml | 1 +
> 3 files changed, 4 insertions(+)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-06 18:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-25 21:27 [PATCH] media: dt-bindings: Add missing unevaluatedProperties on child node schemas Rob Herring
2023-09-26 13:03 ` Conor Dooley
2023-10-06 18:52 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).