From: Oleg Nesterov <oleg@redhat.com>
To: Li kunyu <kunyu@nfschina.com>
Cc: peterz@infradead.org, mcgrof@kernel.org,
mathieu.desnoyers@efficios.com, elver@google.com,
viro@zeniv.linux.org.uk, dvyukov@google.com,
vincent.whitchurch@axis.com, michael.christie@oracle.com,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] kernel/signal: Remove unnecessary ‘NULL’ values from ucounts
Date: Tue, 26 Sep 2023 23:52:34 +0200 [thread overview]
Message-ID: <20230926215233.GA26968@redhat.com> (raw)
In-Reply-To: <20230926022410.4280-1-kunyu@nfschina.com>
On 09/26, Li kunyu wrote:
>
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -415,7 +415,7 @@ __sigqueue_alloc(int sig, struct task_struct *t, gfp_t gfp_flags,
> int override_rlimit, const unsigned int sigqueue_flags)
> {
> struct sigqueue *q = NULL;
> - struct ucounts *ucounts = NULL;
> + struct ucounts *ucounts;
> long sigpending;
this looks obviously correct, so
Acked-by: Oleg Nesterov <oleg@redhat.com>
but you know, this change is so trivial, perhaps you should
resend this minor cleanup to kernel-janitors@vger.kernel.org
but let me add Andrew, perhaps he will take this patch...
Oleg.
prev parent reply other threads:[~2023-09-26 23:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 2:24 [PATCH] kernel/signal: Remove unnecessary ‘NULL’ values from ucounts Li kunyu
2023-09-26 21:52 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230926215233.GA26968@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=kunyu@nfschina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mcgrof@kernel.org \
--cc=michael.christie@oracle.com \
--cc=peterz@infradead.org \
--cc=vincent.whitchurch@axis.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox