* [PATCH] kernel/signal: Remove unnecessary ‘NULL’ values from ucounts
@ 2023-09-26 2:24 Li kunyu
2023-09-26 21:52 ` Oleg Nesterov
0 siblings, 1 reply; 2+ messages in thread
From: Li kunyu @ 2023-09-26 2:24 UTC (permalink / raw)
To: oleg, peterz, mcgrof, mathieu.desnoyers, elver, viro, dvyukov,
vincent.whitchurch, michael.christie
Cc: linux-kernel, Li kunyu
ucounts is assigned first, so it does not need to initialize the
assignment.
Signed-off-by: Li kunyu <kunyu@nfschina.com>
---
kernel/signal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/signal.c b/kernel/signal.c
index 09019017d669..27f6cd37ac4f 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -415,7 +415,7 @@ __sigqueue_alloc(int sig, struct task_struct *t, gfp_t gfp_flags,
int override_rlimit, const unsigned int sigqueue_flags)
{
struct sigqueue *q = NULL;
- struct ucounts *ucounts = NULL;
+ struct ucounts *ucounts;
long sigpending;
/*
--
2.18.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] kernel/signal: Remove unnecessary ‘NULL’ values from ucounts
2023-09-26 2:24 [PATCH] kernel/signal: Remove unnecessary ‘NULL’ values from ucounts Li kunyu
@ 2023-09-26 21:52 ` Oleg Nesterov
0 siblings, 0 replies; 2+ messages in thread
From: Oleg Nesterov @ 2023-09-26 21:52 UTC (permalink / raw)
To: Li kunyu
Cc: peterz, mcgrof, mathieu.desnoyers, elver, viro, dvyukov,
vincent.whitchurch, michael.christie, linux-kernel, Andrew Morton
On 09/26, Li kunyu wrote:
>
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -415,7 +415,7 @@ __sigqueue_alloc(int sig, struct task_struct *t, gfp_t gfp_flags,
> int override_rlimit, const unsigned int sigqueue_flags)
> {
> struct sigqueue *q = NULL;
> - struct ucounts *ucounts = NULL;
> + struct ucounts *ucounts;
> long sigpending;
this looks obviously correct, so
Acked-by: Oleg Nesterov <oleg@redhat.com>
but you know, this change is so trivial, perhaps you should
resend this minor cleanup to kernel-janitors@vger.kernel.org
but let me add Andrew, perhaps he will take this patch...
Oleg.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-26 23:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-26 2:24 [PATCH] kernel/signal: Remove unnecessary ‘NULL’ values from ucounts Li kunyu
2023-09-26 21:52 ` Oleg Nesterov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox