From: Herve Codina <herve.codina@bootlin.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Qiang Zhao <qiang.zhao@nxp.com>, Li Yang <leoyang.li@nxp.com>,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 06/40] soc/fsl: cpm: qmc: Convert to platform remove callback returning void
Date: Wed, 27 Sep 2023 08:44:46 +0200 [thread overview]
Message-ID: <20230927084446.66affc74@bootlin.com> (raw)
In-Reply-To: <20230925095532.1984344-7-u.kleine-koenig@pengutronix.de>
On Mon, 25 Sep 2023 11:54:57 +0200
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/soc/fsl/qe/qmc.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c
> index b3c292c9a14e..92ec76c03965 100644
> --- a/drivers/soc/fsl/qe/qmc.c
> +++ b/drivers/soc/fsl/qe/qmc.c
> @@ -1415,7 +1415,7 @@ static int qmc_probe(struct platform_device *pdev)
> return ret;
> }
>
> -static int qmc_remove(struct platform_device *pdev)
> +static void qmc_remove(struct platform_device *pdev)
> {
> struct qmc *qmc = platform_get_drvdata(pdev);
>
> @@ -1427,8 +1427,6 @@ static int qmc_remove(struct platform_device *pdev)
>
> /* Disconnect the serial from TSA */
> tsa_serial_disconnect(qmc->tsa_serial);
> -
> - return 0;
> }
>
> static const struct of_device_id qmc_id_table[] = {
> @@ -1443,7 +1441,7 @@ static struct platform_driver qmc_driver = {
> .of_match_table = of_match_ptr(qmc_id_table),
> },
> .probe = qmc_probe,
> - .remove = qmc_remove,
> + .remove_new = qmc_remove,
> };
> module_platform_driver(qmc_driver);
>
Acked-by: Herve Codina <herve.codina@bootlin.com>
Best regards,
Hervé
next prev parent reply other threads:[~2023-09-27 6:45 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 9:54 [PATCH 00/40] soc: Convert to platform remove callback returning void Uwe Kleine-König
2023-09-25 9:54 ` [PATCH 01/40] soc/aspeed: aspeed-lpc-ctrl: " Uwe Kleine-König
2023-09-26 1:33 ` Andrew Jeffery
2023-09-25 9:54 ` [PATCH 02/40] soc/aspeed: aspeed-lpc-snoop: " Uwe Kleine-König
2023-09-26 1:30 ` Andrew Jeffery
2023-09-25 9:54 ` [PATCH 03/40] soc/aspeed: aspeed-p2a-ctrl: " Uwe Kleine-König
2023-09-26 1:32 ` Andrew Jeffery
2023-09-25 9:54 ` [PATCH 04/40] soc/aspeed: aspeed-uart-routing: " Uwe Kleine-König
2023-09-26 1:31 ` Andrew Jeffery
2023-09-25 9:54 ` [PATCH 05/40] soc/fsl: dpaa2-console: " Uwe Kleine-König
2023-09-25 9:54 ` [PATCH 06/40] soc/fsl: cpm: qmc: " Uwe Kleine-König
2023-09-27 6:44 ` Herve Codina [this message]
2023-09-25 9:54 ` [PATCH 07/40] soc/fsl: cpm: tsa: " Uwe Kleine-König
2023-09-27 6:44 ` Herve Codina
2023-09-25 9:54 ` [PATCH 08/40] soc/fujitsu: a64fx-diag: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 09/40] soc/hisilicon: kunpeng_hccs: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 10/40] soc/ixp4xx: ixp4xx-npe: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 11/40] soc/ixp4xx: ixp4xx-qmgr: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 12/40] soc/litex: litex_soc_ctrl: " Uwe Kleine-König
2023-09-25 13:03 ` Gabriel L. Somlo
2023-09-25 9:55 ` [PATCH 13/40] soc/loongson: loongson2_guts: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 14/40] soc/mediatek: mtk-devapc: " Uwe Kleine-König
2023-09-26 9:23 ` AngeloGioacchino Del Regno
2023-09-25 9:55 ` [PATCH 15/40] soc/mediatek: mtk-mmsys: " Uwe Kleine-König
2023-09-26 9:23 ` AngeloGioacchino Del Regno
2023-09-25 9:55 ` [PATCH 16/40] soc/microchip: mpfs-sys-controller: " Uwe Kleine-König
2023-09-25 10:20 ` Conor Dooley
2023-09-25 9:55 ` [PATCH 17/40] soc/pxa: ssp: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 18/40] soc/qcom: icc-bwmon: " Uwe Kleine-König
2023-09-25 9:57 ` Konrad Dybcio
2023-09-25 10:39 ` Krzysztof Kozlowski
2023-09-25 9:55 ` [PATCH 19/40] soc/qcom: llcc-qcom: " Uwe Kleine-König
2023-09-25 9:58 ` Konrad Dybcio
2023-09-25 9:55 ` [PATCH 20/40] soc/qcom: ocmem: " Uwe Kleine-König
2023-09-25 9:58 ` Konrad Dybcio
2023-09-25 9:55 ` [PATCH 21/40] soc/qcom: pmic_glink: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 22/40] soc/qcom: qcom_aoss: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 23/40] soc/qcom: qcom_gsbi: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 24/40] soc/qcom: qcom_stats: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 25/40] soc/qcom: rmtfs_mem: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 26/40] soc/qcom: smem: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 27/40] soc/qcom: smp2p: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 28/40] soc/qcom: smsm: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 29/40] soc/qcom: socinfo: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 30/40] soc/rockchip: io-domain: " Uwe Kleine-König
2023-10-01 22:58 ` Heiko Stuebner
2023-09-25 9:55 ` [PATCH 31/40] soc/samsung: exynos-chipid: " Uwe Kleine-König
2023-09-28 5:52 ` (subset) " Krzysztof Kozlowski
2023-09-25 9:55 ` [PATCH 32/40] soc/tegra: cbb: tegra194-cbb: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 33/40] soc/ti: k3-ringacc: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 34/40] soc/ti: knav_dma: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 35/40] soc/ti: knav_qmss_queue: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 36/40] soc/ti: pm33xx: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 37/40] soc/ti: pruss: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 38/40] soc/ti: smartreflex: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 39/40] soc/ti: wkup_m3_ipc: " Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 40/40] soc/xilinx: zynqmp_power: " Uwe Kleine-König
2023-10-02 9:13 ` Michal Simek
2023-09-25 9:58 ` [PATCH 00/40] soc: " Konrad Dybcio
2023-09-27 2:25 ` Joel Stanley
2023-09-27 8:43 ` Arnd Bergmann
2023-09-27 23:01 ` Bjorn Andersson
2023-09-28 6:14 ` Uwe Kleine-König
2023-10-14 21:59 ` [GIT PULL] Convert drivers/soc to struct platform_driver::remove_new() Uwe Kleine-König
2023-10-02 14:13 ` (subset) [PATCH 00/40] soc: Convert to platform remove callback returning void Nishanth Menon
2023-10-03 1:10 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230927084446.66affc74@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=kernel@pengutronix.de \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=qiang.zhao@nxp.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).