Re: [PATCH] ASoC: codecs: rtq9128: Add TDM data source selection

Mark Brown
2023-09-27T10:28:36Z

[-- Attachment #1: Type: text/plain, Size: 1035 bytes --]

On Wed, Sep 27, 2023 at 06:19:48PM +0800, ChiYuan Huang wrote:
> On Wed, Sep 27, 2023 at 11:59:31AM +0200, Mark Brown wrote:

> > Sure, but is that actually a practical design - or if someone is doing
> > this shouldn't it be joined up with the TDM configuration since with
> > just the control it'd only be possible to switch the pins but not change
> > the TDM layout? I'm not sure that this control works as a standalone
> > thing.

> I think if two data source input for different scenarios, then the data source
> switch will become practical. For the standalone usage, keep a device property
> to decide this may be enough. But consider the future application, to keep this
> in general mixer control is still usable to meet the complex design.

My concern is that the control might not actually be usable without also
changing the TDM mode so we might need the machine driver to add a
control which flips the input and also changes the TDM mode - it feels
likley that if there are two inputs they won't have identical formats.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]