Re: [PATCH] ASoC: codecs: rtq9128: Add TDM data source selection

Mark Brown
2023-09-27T09:13:32Z

[-- Attachment #1: Type: text/plain, Size: 827 bytes --]

On Wed, Sep 27, 2023 at 10:06:16AM +0800, cy_huang@richtek.com wrote:

> Since rtq9128 can support 4 channel I2S mode audio data, there are two
> dedicated data input pins for CH12 and CH34. But in TDM mode, input
> source was already drived on one data pin for multiple data slots. In
> this case, only one input source is needed for TDM mode.
>
> This patch is to add the data source pin selection for CH12 and CH34.

> + SOC_ENUM("CH12 TDM Data Select", rtq9128_ch12_tdm_data_select_enum),
> + SOC_ENUM("CH34 TDM Data Select", rtq9128_ch34_tdm_data_select_enum),

Is this something that's going to be changing dynamically at runtime or
should this be a device property that's set either by firmware or when
we're doing the TDM setup? This sounds like something I'd expect to be
fixed by the board design.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]